Feat/charge withdraw improvements - #545
Open
janetpius-cmd wants to merge 4 commits into
Open
Conversation
Prepend the newly created withdrawal to local state as soon as the create call succeeds instead of waiting on a full refetch that could race the write, and poll withdrawals/balances in the background so status transitions (pending -> completed/failed) show up without a manual reload. Claude-Session: https://claude.ai/code/session_01LJBRoinS4QS6tAyWh4mKva
Replace the hardcoded XLM asset on the charge screen with a selector between XLM and cNGN. cNGN stays disabled and labelled "Coming soon" until NEXT_PUBLIC_CNGN_ISSUER is configured, and the charge flow never silently falls back to XLM if the requested asset has no SEP-7 URI. Claude-Session: https://claude.ai/code/session_01LJBRoinS4QS6tAyWh4mKva
Add a "Note / memo" input to the charge screen and thread it through api.createPaymentRequest. The QR receipt page already displayed the memo field, so a merchant-supplied note now shows up there for the customer with no further changes needed. Claude-Session: https://claude.ai/code/session_01LJBRoinS4QS6tAyWh4mKva
Reuse components/onramp/countdown-timer.tsx on the payment request page instead of its own inline countdown, turn it amber under 60s remaining, flip to an expired view the instant the client clock hits zero (rather than waiting on the next status poll), and add a "Generate new code" button that recreates the charge with the same amount, asset, and memo. Claude-Session: https://claude.ai/code/session_01LJBRoinS4QS6tAyWh4mKva
|
@janetpius-cmd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@janetpius-cmd is attempting to deploy a commit to the kelly musk's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description:
Closes #453
Closes #454
Closes #455
Closes #456
Type of Change
Changes Made
Testing
npm run dev)npm test)npm test)NEXT_PUBLIC_DEMO_MODE=false)Test steps for reviewers:
Screenshots / Screen Recording
Checklist
Code Quality
npm run lint)anywithout justification):npm run type-checkNEXT_PUBLIC_*variables added to.env.example(if applicable)Observability
captureError/logfromlib/observabilitycaptureErrorlog.*orcaptureErrorSecurity
NEXT_PUBLIC_*variablesAccessibility (UI changes only)
aria-label,aria-describedby)Documentation
SECURITY.mdupdated if the change affects the security surface (rare)Deployment Notes
Related Issues / PRs