This repository was archived by the owner on Aug 7, 2026. It is now read-only.
ci: switch dockerhub login to OIDC - #13
Open
ingwarsw wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Docker image publish workflow to authenticate to Docker Hub using GitHub OIDC instead of long-lived Docker Hub username/password secrets.
Changes:
- Adds
id-token: write(and explicitcontents: read) permissions to thedockerjob for OIDC. - Replaces
docker/login-actionsecret-based auth withdocker/oidc-actiontoken exchange +docker/login-actionusing the OIDC token.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+37
| permissions: | ||
| contents: read | ||
| id-token: write |
Comment on lines
47
to
+49
| with: | ||
| username: ${{ secrets.DOCKER_HUB_USERNAME }} | ||
| password: ${{ secrets.DOCKER_HUB_PASSWORD }} | ||
| connection-id: "24b78b4d-ffde-4850-a999-76d7bbaf3214" | ||
| expires-in: 1800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
DOCKER_HUB_USERNAME/DOCKER_HUB_PASSWORDsecrets in thedockerjob with thedocker/oidc-action+docker/login-actionOIDC flow, matching the pattern rolled out across other repos (see kentik/ksynth#14, kentik/kagent#1004).permissions: contents: read, id-token: writeto thedockerjob.docker/login-action@v1usingDOCKER_HUB_USERNAME/DOCKER_HUB_PASSWORDwithdocker/oidc-action+docker/login-actionusing thekentikOIDC connection.