yanger: expand VLAN ranges from bridge global output#1517
Merged
Conversation
bridge -j vlan global show can return VLAN ranges as
{"vlan": 1, "vlanEnd": 3} instead of individual entries.
The vlans dict was only keyed on the start value, causing
port VLANs 2 and 3 to be reported as "Unexpected".
Also fix typo in error message (brpvlans -> brpvlan).
wkz
approved these changes
May 26, 2026
Contributor
wkz
left a comment
wkz
left a comment
There was a problem hiding this comment.
The laundry room strikes again! 😆
troglobit
reviewed
May 26, 2026
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Awesome work, and I'm not saying this enough, you're probably doing more for Infix than anyone else of the coreteam atm. Your continued work is not going unnoticed, my friend! ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bridge -j vlan global show can return VLAN ranges as {"vlan": 1, "vlanEnd": 3} instead of individual entries. The vlans dict was only keyed on the start value, causing port VLANs 2 and 3 to be reported as "Unexpected".
Also fix typo in error message (brpvlans -> brpvlan).
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: