Fix for cmake check_include_file - #32
Merged
Merged
Conversation
added 2 commits
July 29, 2026 15:24
It is used outside, and other checks fail then this condition is false
Contributor
|
Yes, your PR looks correct (thanks!) - I suspect bzip2 is installed on all of the build environments I've been using, so I've never bumped into this failure mode. Thanks for the PR. |
arahlin
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing cmake, I found this issue where if bzip2 dev files aren't installed, then
check_include_filewill fail in some later uses, since itsincludeis conditional.This fix solved the problem for me. But I don't know much about
cmakeso am open to suggestions.