Fix TracksFromGenParticles - build tracks only for particles that reach the calorimeter#86
Open
SanghyunKo wants to merge 1 commit into
Open
Fix TracksFromGenParticles - build tracks only for particles that reach the calorimeter#86SanghyunKo wants to merge 1 commit into
SanghyunKo wants to merge 1 commit into
Conversation
Collaborator
Author
|
Release CI is expected to fail without key4hep/k4geo#581. For nightly CI, it seems that one of the tests is using too much memory (nothing relevant to the PR): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Currently a track is built for every charged MCParticle with a matched hit, which gives unphysical tracks: unstable baryons (Σ, Ξ, Ω, D…) that decay in the tracker, and both the parent and daughter of an in-flight decay (e.g. π/K → μ), so the same trajectory is double-counted.
Fix: skip particles with
isDecayedInTracker()(newOnlyCaloReachingParticlesproperty, default true). This drops the ghosts and in-flight-decay parents while keeping the calo-reaching daughter. Set the property false for the old behaviour.Also skip charged particles with pt = 0 (exactly along the beam): their helix is singular (omega, tanLambda, Z0 → non-finite) and crashes the downstream Pandora track creation.