Skip to content

Fix TracksFromGenParticles - build tracks only for particles that reach the calorimeter#86

Open
SanghyunKo wants to merge 1 commit into
key4hep:mainfrom
SanghyunKo:dev_fixTracksFromGenPtc
Open

Fix TracksFromGenParticles - build tracks only for particles that reach the calorimeter#86
SanghyunKo wants to merge 1 commit into
key4hep:mainfrom
SanghyunKo:dev_fixTracksFromGenPtc

Conversation

@SanghyunKo

Copy link
Copy Markdown
Collaborator

BEGINRELEASENOTES

  • Fix TracksFromGenParticles - build tracks only for particles that reach the calorimeter

ENDRELEASENOTES

Currently a track is built for every charged MCParticle with a matched hit, which gives unphysical tracks: unstable baryons (Σ, Ξ, Ω, D…) that decay in the tracker, and both the parent and daughter of an in-flight decay (e.g. π/K → μ), so the same trajectory is double-counted.

Fix: skip particles with isDecayedInTracker() (new OnlyCaloReachingParticles property, default true). This drops the ghosts and in-flight-decay parents while keeping the calo-reaching daughter. Set the property false for the old behaviour.

Also skip charged particles with pt = 0 (exactly along the beam): their helix is singular (omega, tanLambda, Z0 → non-finite) and crashes the downstream Pandora track creation.

@SanghyunKo

Copy link
Copy Markdown
Collaborator Author

Release CI is expected to fail without key4hep/k4geo#581.

For nightly CI, it seems that one of the tests is using too much memory (nothing relevant to the PR):

real	4m3.444s
user	10m2.917s
sys	1m23.002s
Cacheable calls:    60 /  60 (100.0%)
  Hits:              0 /  60 ( 0.00%)
    Direct:          0
    Preprocessed:    0
  Misses:           60 /  60 (100.0%)
Local storage:
  Cache size (GB): 0.5 / 0.5 (103.1%)
  Cleanups:         50
  Hits:              0 /  60 ( 0.00%)
  Misses:           60 /  60 (100.0%)
Test project /k4rectracker/build
    Start 3: test_runDCHdigiV1
    Start 8: test_TrackFinder
    Start 1: test_DCHsimpleDigitizer
    Start 2: test_DCHsimpleDigitizerExtendedEdm
1/9 Test #3: test_runDCHdigiV1 ....................   Passed   89.17 sec
    Start 4: test_runDCHdigiV2
2/9 Test #4: test_runDCHdigiV2 ....................   Passed    2.91 sec
    Start 5: test_runVTXdigitizer
3/9 Test #1: test_DCHsimpleDigitizer ..............   Passed  180.69 sec
    Start 6: test_VTXdigitizerDetailed
4/9 Test #2: test_DCHsimpleDigitizerExtendedEdm ...   Passed  182.12 sec
    Start 7: test_TracksFromGenParticles
5/9 Test #6: test_VTXdigitizerDetailed ............   Passed   61.42 sec
/home/runner/work/_temp/d69dfa95-b515-44b1-8a9a-d59ba5052669.sh: line 115:  2431 Killed                  docker exec container /bin/bash -c "/mount.sh && /${name}/script_container.sh"
Error: Process completed with exit code 137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant