This repository was archived by the owner on Sep 10, 2026. It is now read-only.
Fix tests - #130
Merged
Merged
Fix tests#130
Conversation
brianhelba
commented
Jan 17, 2026
Comment on lines
-18
to
-19
| np._typing.NDArray[np.uint8]: A numpy uint8 3D array (image) to | ||
| render. |
Contributor
Author
There was a problem hiding this comment.
Docstrings are nice for explaining the semantics of parameters and return values, but I think we should avoid duplicating type information in them.
Of course, before formal Python typing via language syntax, it was more common to put type information in docstrings.
brianhelba
commented
Jan 17, 2026
Comment on lines
+9
to
+10
| if TYPE_CHECKING: | ||
| import numpy.typing as npt |
Contributor
Author
There was a problem hiding this comment.
See https://numpy.org/doc/stable/reference/typing.html#api and other usage in the code.
For a rigorous library like numpy, there ought to be no need to import private symbols (it's a red flag that "there ought to be a better way"). I appreciate this doesn't hold for other lower-software-quality libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.