Skip to content

feat: use lend/filter for saved searches, augment url where needed - #4379

Open
mcstover wants to merge 1 commit into
mainfrom
saved-search-url-lend-filter
Open

feat: use lend/filter for saved searches, augment url where needed#4379
mcstover wants to merge 1 commit into
mainfrom
saved-search-url-lend-filter

Conversation

@mcstover

Copy link
Copy Markdown
Collaborator

This PR updates the saved search page /lend/saved-search to link to /lend/filter instead of legacy lend.

  • updates the url path
  • removes unnecessary loanLimit param when unset (ie, set to -1)
  • removed duplicated separators after query param changes

@mcstover

Copy link
Copy Markdown
Collaborator Author

Need to do a bit more validation and testing, potentially accomodating other filter formatting

Comment thread src/components/Settings/SaveSearchItem.vue
@mcstover

Copy link
Copy Markdown
Collaborator Author

@dyersituations if any other query params come to mind that need a query param map to be compatible with lend/filter please let me know and we can fold it in here before merging.

@dyersituations

Copy link
Copy Markdown
Collaborator

@dyersituations if any other query params come to mind that need a query param map to be compatible with lend/filter please let me know and we can fold it in here before merging.

The only one at the moment I think is the distribution model ticket, but it's not related 100% to saved search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants