feat: mp-3058-meta-tracking-new-events-pt-2 - #7133
Merged
infante-jaime merged 7 commits intoAug 10, 2026
Merged
Conversation
mcstover
reviewed
Aug 4, 2026
cristhianDt
reviewed
Aug 4, 2026
christian14b
reviewed
Aug 4, 2026
infante-jaime
marked this pull request as draft
August 4, 2026 18:02
infante-jaime
marked this pull request as ready for review
August 10, 2026 04:10
Collaborator
|
@infante-jaime since some of the comments aren't auto-marked as "outdated", please go through the comments on this PR and respond + resolve. |
dyersituations
approved these changes
Aug 10, 2026
cristhianDt
reviewed
Aug 10, 2026
cristhianDt
left a comment
cristhianDt
left a comment
Contributor
There was a problem hiding this comment.
👍 thanks for use my recommendations 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MP-3012 — Meta tracking: new lender events (pt. 2, ui)
Adds four Meta custom events, following the pattern from pt. 1
(
idleLenderReEngaged/lapsedLenderReEngaged). The ticket's two giving-fundevents live in cms-page-server and are handled separately.
donationkivaCardRedemptionemailSignUplenderNews === true && !globalUnsubscribed, since the same mutations serve opt-outs.accountCreatedAll fire on confirmed success — after the mutation or transaction resolves, never at
form submit.
New:
src/util/metaEvents.js(event names +trackMetaEvent, so delivery canchange in one place),
src/util/registrationTracking.js.Modified:
kv-analytics-plugin.js,InstantDonationThanks.vue,KivaCardRedemption.vue,useOptIn.js,CheckoutPage.vue,client-entry.js.