fix: prevent infinite UserPreferences refetch loop on MyKiva page - #7142
Draft
jmallatt-kiva wants to merge 1 commit into
Draft
fix: prevent infinite UserPreferences refetch loop on MyKiva page#7142jmallatt-kiva wants to merge 1 commit into
jmallatt-kiva wants to merge 1 commit into
Conversation
jmallatt-kiva
marked this pull request as draft
August 6, 2026 05:04
| // Watch the cache only; a watcher with a network fetch policy refetches on | ||
| // every cache broadcast, which loops indefinitely (hammering the gateway) | ||
| // if the resolver keeps returning partial data (200 + errors). | ||
| this.userPreferencesSubscription = this.apollo.watchQuery({ |
Collaborator
There was a problem hiding this comment.
userPreferencesSubscription needs to be added to data()
|
|
||
| // Single network fetch to populate the cache; the watcher above receives | ||
| // this result and any later userPreferences mutation writes. | ||
| await this.apollo.query({ query: userPreferencesQuery }); |
Collaborator
There was a problem hiding this comment.
Doesn't the watchQuery above also trigger an initial query?
Collaborator
There was a problem hiding this comment.
Yea it should. In general this was part of several of us debugging with claude. I think in this case, it really depends on what and when the cache might get updated. I though I recalled you had some other in-page actions that could update user preferences. If so, those would need to force a network call or otherwise deliberately update the cache with the new data for this approach to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UserPreferences watchQuery in mounted() had no error handling and
refetched on every cache broadcast. With errorPolicy 'all' (the client
default), a resolver returning partial data (200 + errors) writes an
incomplete result to the cache, so the watched query can never be
satisfied and Apollo reobserves/refetches in a tight loop (~14 POST/s
per tab against Stellate, observed during the 2026-08-06 maintenance
window).
Watch the cache only (cache-only watchers can never trigger network
requests), populate it with a single one-shot query, log watcher
errors, and unsubscribe on unmount.