Add Etcd resource calculator and ops-request mapping - #98
Merged
Merged
Conversation
Registers Etcd (kubedb.com/v1alpha2 and gitops.kubedb.com/v1alpha1) with the same shape as ZooKeeper -- the closest architectural sibling already in this repo, a single-role consensus ensemble with an optional Prometheus exporter sidecar, standalone below 2 replicas and ensemble at or above. Also adds the ops.kubedb.com/v1alpha1 EtcdOpsRequest path mapping for horizontal/vertical scaling and volume expansion, using the field names EtcdVerticalScalingSpec and EtcdVolumeExpansionSpec actually declare (etcd/exporter), mirroring how Redis's mapping is shaped rather than ZooKeeper's single 'node' field. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Etcd(kubedb.com/v1alpha2andgitops.kubedb.com/v1alpha1) with aResourceCalculator, following ZooKeeper's shape (the closest architectural sibling already in this repo: a single-role consensus ensemble with an optional Prometheus exporter sidecar). Standalone below 2 replicas, ensemble at or above.ops.kubedb.com/v1alpha1EtcdOpsRequestpath mapping for horizontal scaling, vertical scaling, and volume expansion, using the field namesEtcdVerticalScalingSpec/EtcdVolumeExpansionSpecactually declare (etcd/exporter), mirroring how Redis's mapping is shaped rather than ZooKeeper's singlenodefield.EtcdContainerNameto the shared constants block.Test plan
go build ./...go vet ./...gofmt -l .cleango test ./...— full repo suite passes, including the two newTestEtcdfixtures (standalone/ensemble) underkubedb.com/v1alpha2