Add resource calculators for elasticsearch.kubedb.com and postgres.kubedb.com - #99
Merged
Merged
Conversation
…bedb.com Register ElasticsearchDashboard with replicas from spec.replicas and app resources from the elasticsearch container in spec.podTemplate, plus the prometheus exporter sidecar. Publisher and Subscriber only configure logical replication on an existing Postgres instance, so they register zero-resource calculators to keep their GVKs resolvable. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds resource-metrics calculators for the kinds in
kubedb.dev/apimachinery/apis/elasticsearchandapis/postgres.elasticsearch.kubedb.com/v1alpha1
ElasticsearchDashboard: replicas fromspec.replicas(default 1), app resources from theelasticsearchcontainer inspec.podTemplate, exporter fromspec.monitor.prometheus.exporter,UsesTLSkeyed onspec.tlspresence. Modeled on the existingConnectClustercalculator.postgres.kubedb.com/v1alpha1
PublisherandSubscriberonly configure logical replication on an existing Postgres instance — no pods are created for them — so they register zero-resource calculators. This keeps their GVKs resolvable for callers instead of failing on an unregistered kind.Other
calculator.go: blank imports for both new packages.Makefile: added the two new dirs toSRC_PKGSsomake fmtcovers them. Notekafka.kubedb.comis still missing from that list (pre-existing, left alone here).