chore: include package.json in package exports maps#1027
Merged
Conversation
Expose "./package.json" in the exports map for client, react, react-core, react-native, and expo so tooling (bundlers, test mockers like Storybook/Vitest, version checks) can resolve the package manifest. Closes #1026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: dc8ef79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kylemcd
requested review from
andy-knock,
cjbell and
thomaswhyyou
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
+ Coverage 63.95% 64.46% +0.51%
==========================================
Files 212 212
Lines 10028 10211 +183
Branches 1321 1389 +68
==========================================
+ Hits 6413 6583 +170
- Misses 3590 3603 +13
Partials 25 25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
"./package.json": "./package.json"to theexportsmap of the five published packages that define one:@knocklabs/client,@knocklabs/react,@knocklabs/react-core,@knocklabs/react-native, and@knocklabs/expo.Why: once a package declares an
exportsfield, that field becomes a hard encapsulation boundary — any subpath not explicitly listed (including./package.json) becomes unresolvable. A lot of tooling relies on being able to resolve a dependency's manifest: bundlers, version/feature detection, and test mockers like Storybook and Vitest. Without this entry,sb.mock(import("@knocklabs/react"))throwsPackage subpath './package.json' is not defined by "exports".Exposing
./package.jsonis the accepted convention (React, Vite, Zod, most of@babel/*, etc. all do it) and is zero-risk — the file is already published.@knocklabs/typesis intentionally untouched because it has noexportsmap.Checklist
Closes #1026
KNO-14073