Skip to content

Chore: update debounce value - #182

Open
koukibadr wants to merge 2 commits into
mainfrom
chore/debounce/update-debounce-value
Open

Chore: update debounce value#182
koukibadr wants to merge 2 commits into
mainfrom
chore/debounce/update-debounce-value

Conversation

@koukibadr

@koukibadr koukibadr commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features
    • Async search filtering now waits three seconds after typing before applying results, reducing unnecessary updates.
    • Searchable lists automatically dismiss keyboard focus when removed from the screen.
  • Style
    • Updated the example app with improved spacing around searchable lists.
    • Refined the development editor’s status bar and activity bar colors.
  • Documentation
    • Renamed the README’s “Authors” section to “Contributors.”
  • Chores
    • Updated Android example project settings for current build tooling.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@koukibadr, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a7b4ef34-730b-4bf5-bb76-5a3abd546bb1

📥 Commits

Reviewing files that changed from the base of the PR and between f8ce91a and 2fd23b8.

📒 Files selected for processing (3)
  • .vscode/settings.json
  • README.md
  • lib/searchable_listview.dart
📝 Walkthrough

Walkthrough

The pull request changes async filtering defaults and lifecycle logging, adjusts focus disposal behavior, adds spacing to example tabs, updates Android flags, expands VS Code colors, and renames the README contributor section.

Changes

Searchable listview updates

Layer / File(s) Summary
Async filtering and lifecycle behavior
lib/searchable_listview.dart
Async filtering now defaults to a 3000 ms debounce, logs filtering and disposal events, and unfocuses the primary focus during disposal.
Example app layout and Android configuration
example/lib/main.dart, example/android/gradle.properties
Four example tabs receive symmetric padding, and two Flutter-migrator Android/Gradle flags are added.
Project presentation settings
.vscode/settings.json, README.md
VS Code color customizations are expanded, and the README heading changes from Authors to Contributors.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit taps the search box bright,
Three seconds hush the typing light.
Tabs wear cushions, colors glow,
Contributors’ names now softly show.
Hop, hop—clean changes in a row!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main functional change: increasing the async debounce value in the searchable list widget.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/searchable_listview.dart`:
- Line 557: Update the cleanup around the searchable list’s focus handling to
avoid calling FocusManager.instance.primaryFocus?.unfocus() unconditionally.
Unfocus only the focus node owned by this searchable list, or move the cleanup
into the search-field component that owns that node, preserving focus in
unrelated fields when the list is disposed.
- Line 92: Add a regression test covering the 3000 ms default assigned by the
SearchableListView constructor, including the downstream async test path. Omit
asyncDebounceTime, use a query that changes the filtered results, advance the
test clock beyond 3000 ms explicitly, and then verify the updated results
instead of relying on pumpAndSettle alone.
- Line 809: Update the logging around the filtering operation to avoid including
the raw value from the search input. In the filtering logic containing the log
statement, record only that filtering occurred, unless an explicit
development-only diagnostic flag permits detailed query logging.
- Around line 555-557: Update the SearchableListView dispose flow to cancel
pending asynchronous work before the widget is torn down: dispose the _debouncer
and cancel or invalidate _activeOperation so queued callbacks cannot invoke
asyncListFilter after disposal. Keep the existing focus-unfocus behavior intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9d4926b9-962d-42d7-9be5-4e10fcbb2bb0

📥 Commits

Reviewing files that changed from the base of the PR and between 87c203a and f8ce91a.

⛔ Files ignored due to path filters (1)
  • example/pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • .vscode/settings.json
  • README.md
  • example/android/gradle.properties
  • example/lib/main.dart
  • lib/searchable_listview.dart

Comment thread lib/searchable_listview.dart
Comment thread lib/searchable_listview.dart Outdated
Comment thread lib/searchable_listview.dart Outdated
Comment thread lib/searchable_listview.dart
@koukibadr
koukibadr force-pushed the chore/debounce/update-debounce-value branch from f8ce91a to 2fd23b8 Compare July 20, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant