chore(lint): clear all 64 oxlint warnings repo-wide - #502
Open
krasnoperov wants to merge 1 commit into
Open
Conversation
All five warning categories addressed; zero warnings, zero errors
after this change. No behavior change.
- no-useless-fallback-in-spread (21): removed `?? {}` fallbacks from
spreads. Spreading a falsy value is already a no-op, so the
fallback was dead code.
- no-unused-vars (32): removed unused imports, variables, type
aliases, and parameters across src/, packages/merge-steward/,
and packages/review-quill/. Where a parameter is required by an
external signature, prefixed with `_`.
- no-useless-spread (7): unwrapped a few `...({...} ? {...} : {})`
patterns that produced new objects only to spread them.
- no-constant-condition (2): replaced `do { ... } while (true)` in
CLI poll loops with conditions that the existing exit checks
satisfy. The throw-on-deadline path is preserved.
- no-unsafe-optional-chaining (2): in
test/linear-progress-reporter.test.ts, replaced
`(emitted[i]?.content as { body? }).body` with
`((emitted[i]?.content ?? {}) as { body? }).body` so a missing
index doesn't TypeError before the cast resolves.
![review-quill[bot]](https://avatars.githubusercontent.com/u/4581825?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All five warning categories cleared; lint is now 0 warnings, 0 errors. No behavior change.
41 files changed, +70/-81. Repo-wide `pnpm test` (644 tests) still green; `pnpm typecheck` clean.
Why now
The merge-trees rollout (PRs #483-#501) brought lint warnings as a side effect. Clearing them as a separate PR keeps the main feature work focused on behavior changes; this is purely housekeeping.