Skip to content

fix: explain completed issue reopen behavior - #635

Open
krasnoperov wants to merge 1 commit into
mainfrom
feature/explain-completed-issue-reopen
Open

fix: explain completed issue reopen behavior#635
krasnoperov wants to merge 1 commit into
mainfrom
feature/explain-completed-issue-reopen

Conversation

@krasnoperov

Copy link
Copy Markdown
Owner

Summary

  • post a clear Linear comment when PatchRelay restores reopened completed work to Done
  • point follow-up work to a new Linear issue and link the merged delivery PR when available
  • keep the state repair best-effort when the Linear comment API fails

Verification

  • node --experimental-transform-types --test test/merged-linear-completion-reconciler.test.ts (10/10)
  • pnpm typecheck
  • pnpm lint
  • pnpm test (1025/1025)

@review-quill review-quill Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: 🛑 Request changes — The explanation must be posted only after the state restoration succeeds to avoid misleading duplicate comments during retryable Linear failures.

return;
}

await this.commentOnCompletedIssueReopen(issue, linear);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 If Linear creates the comment but transiently rejects setIssueState, each normal retry creates another comment and claims a restoration that has not happened.

Suggested change
await this.commentOnCompletedIssueReopen(issue, linear);
const updated = await linear.setIssueState(issue.linearIssueId, targetState);
await this.commentOnCompletedIssueReopen(issue, linear);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant