fix: replace migrations with final schema bootstrap - #640
Merged
Conversation
| } finally { | ||
| connection.exec("PRAGMA foreign_keys = ON"); | ||
| } | ||
| connection.exec(schema); |
There was a problem hiding this comment.
🚨 If a fresh install stops mid-exec, the next startup sees the first created table and refuses to resume, leaving the database incomplete. Make the bootstrap atomic.
Suggested change
| connection.exec(schema); | |
| connection.transaction(() => connection.exec(schema))(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PatchRelay runs one production SQLite database that is already on the current schema. Startup compatibility migrations were still rebuilding
issuesthroughissues_new,DROP TABLE, andRENAME, which could destroy the live schema when interrupted.What changed
CREATE TABLE/INDEX IF NOT EXISTSExisting older schemas are intentionally unsupported; this deployment targets the single current production database.
Validation
pnpm run ci— 1024 tests, lint, typecheck, and build passPRAGMA integrity_checkisok