chore(channels): surface only Slack + Desktop; hide email + telegram - #8
Merged
Merged
Conversation
Email and Telegram are untested delivery paths. Keep their notifier code, Config dataclasses, and load_config parsers intact — a hand-added [channels.email] / [channels.telegram] section still loads and delivers — but remove them from every user-facing entry point so the surfaced set is Slack and Desktop only: - TUI: ChannelsScreen, the main-menu/review summaries, and the per-channel TelegramScreen no longer offer email or telegram (email was already absent). - config_to_toml writes only [channels.slack] and [channels.desktop]; a TUI re-save drops any unsurfaced section it did not write. - validate_config names Slack/Desktop in its guidance (the enablement check still counts a hand-configured email/telegram); drop the telegram-specific field validation (the TUI can no longer enable it). - cli first-run check now counts desktop too. - README / SECURITY / CLAUDE: document Slack + Desktop; CLAUDE notes the hidden channels remain functional code. Tests updated to assert the surfaces are gone while the loaders still accept a hand-added section. Co-Authored-By: Penny-One (Batcave) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Email and Telegram are untested delivery paths. This hides them rather than deleting them: the notifier code,
Configdataclasses, andload_configparsers stay intact, so a hand-added[channels.email]/[channels.telegram]section still loads and delivers. Only the user-facing entry points are removed, leaving Slack + Desktop as the surfaced channels.Changes
tui/screens.py):ChannelsScreenand the main-menu / review summaries offer only Slack + Desktop; the per-channelTelegramScreenis removed (email was already absent from the TUI).tui/configio.py):config_to_tomlwrites only[channels.slack]and[channels.desktop]. A TUI re-save drops any unsurfaced section it didn't write.validate_confignames Slack/Desktop in its guidance (the enablement check still counts a hand-configured email/telegram); the telegram-specific field validation is dropped since the TUI can no longer enable it.cli.py): the first-run check now counts desktop too.Kept intact (the "code")
notify/email.py,notify/telegram.py, their registry registration,EmailChannel/TelegramChannel, and theload_configloaders — verified by the existingtests/notify/test_email.pyandtests/notify/test_telegram.pynotifier suites, plus new tests asserting a hand-added section still loads.Testing
uv run pytest— 482 passed.ruff check/ruff format --checkclean.🦇 Generated by Penny-One at Batcave