Skip to content

chore: remove submodules and add depencies via FetchContent #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kshku merged 4 commits into from
Jun 10, 2026
Merged

chore: remove submodules and add depencies via FetchContent #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef50b5b
chore: remove submodules
kshku Jun 10, 2026
684e506
chore: update the CMake configuration to use FetchContent
kshku Jun 10, 2026
0934b5e
fix: update codebase according to changes in dependancies
kshku Jun 10, 2026
4a96e55
chore: remove empty .gitmodules file
kshku Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .gitmodules
View file
Open in desktop

This file was deleted.

25 changes: 24 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,30 @@ target_compile_definitions(snuk_configs INTERFACE

option(SNUK_BUILD_SHARED "Build shared library" OFF)

add_subdirectory(external)
include(FetchContent)

FetchContent_Declare(
snlogger
GIT_REPOSITORY https://github.com/kshku/SnLogger.git
GIT_TAG main
)
FetchContent_MakeAvailable(snlogger)

FetchContent_Declare(
snfile
GIT_REPOSITORY https://github.com/kshku/SnFile.git
GIT_TAG main
)
FetchContent_MakeAvailable(snfile)

FetchContent_Declare(
snmemory
GIT_REPOSITORY https://github.com/kshku/SnMemory.git
GIT_TAG main
)

target_link_libraries(snuk_configs INTERFACE snlogger snfile snmemory)

add_subdirectory(docs)
add_subdirectory(src)
add_subdirectory(repl)
Expand Down
1 change: 0 additions & 1 deletion external/SnFile
Open in desktop
Submodule SnFile deleted from 993e29
1 change: 0 additions & 1 deletion external/SnLogger
Open in desktop
Submodule SnLogger deleted from 534235
1 change: 0 additions & 1 deletion external/SnMemory
Open in desktop
Submodule SnMemory deleted from b0e1d5
2 changes: 1 addition & 1 deletion src/memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void snuk_free(void *ptr) {

static bool create_allocator(SnukPageAllocator *allocator, uint32_t pages) {
*allocator = (SnukPageAllocator){
.base = sn_vm_reserve(pages),
.base = sn_vm_reserve(NULL, pages),
.total_pages = pages,
.committed_pages = 0,
.reverse_committed_pages = 0,
Expand Down
Loading