fix new-counter-demo HTTP publish error handling - #170
Open
blackdragoon26 wants to merge 2 commits into
Open
Conversation
kubeedge-bot
added
do-not-merge/work-in-progress
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blackdragoon26 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
|
Welcome @blackdragoon26! It looks like this is your first PR to kubeedge/examples 🎉 |
kubeedge-bot
added
the
size/S
blackdragoon26
marked this pull request as ready for review
August 14, 2026 11:51
kubeedge-bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Sankalp Jha <sankalp.jha9643@gmail.com>
blackdragoon26
force-pushed
the
fix/counter-http-error-guard
branch
from
August 14, 2026 11:55
0924d22 to
5b8a4ef
Compare
Author
|
@Catherine-monk, @Shelley-BaoYue |
Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
blackdragoon26
force-pushed
the
fix/counter-http-error-guard
branch
from
August 24, 2026 14:11
4db6ebe to
7b6f029
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Prevents the new-counter-demo HTTP push method from dereferencing a nil response after a failed
http.Postcall. The error is logged and the publish attempt returns cleanly. A focused regression test uses a malformed endpoint so the transport failure is deterministic.Which issue(s) this PR fixes:
Fixes #169
Special notes for your reviewer:
Validation:
go test ./data/publish/httpDoes this PR introduce a user-facing change?: