fix new-counter-demo MQTT connection error handling - #172
Open
blackdragoon26 wants to merge 2 commits into
Open
Conversation
kubeedge-bot
added
kind/bug
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blackdragoon26 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/S
blackdragoon26
marked this pull request as ready for review
August 14, 2026 11:50
kubeedge-bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Sankalp Jha <sankalp.jha9643@gmail.com>
blackdragoon26
force-pushed
the
fix/counter-mqtt-connect-error
branch
from
August 14, 2026 11:55
2e42320 to
350e9e5
Compare
Author
|
@Shelley-BaoYue @wbc6080 |
Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
blackdragoon26
force-pushed
the
fix/counter-mqtt-connect-error
branch
from
August 24, 2026 14:11
f3acf85 to
cea9c87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Prevents the new-counter-demo MQTT push method from terminating the entire virtual protocol process when the broker connection fails. The error is logged and the current publish attempt returns. A focused regression test covers an invalid broker address.
Which issue(s) this PR fixes:
Fixes #171
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: