Skip to content

fix new-counter-demo web UI upstream status handling - #174

Open
blackdragoon26 wants to merge 2 commits into
kubeedge:masterfrom
blackdragoon26:fix/counter-web-upstream-status
Open

fix new-counter-demo web UI upstream status handling#174
blackdragoon26 wants to merge 2 commits into
kubeedge:masterfrom
blackdragoon26:fix/counter-web-upstream-status

Conversation

@blackdragoon26

@blackdragoon26 blackdragoon26 commented Aug 14, 2026

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

Makes the new-counter-demo web UI validate KubeEdge API response status codes before returning success. Non-2xx upstream responses now return an upstream error response instead of being reported as successful operations.

The regression coverage checks the shared 2xx boundary and exercises all five handlers against a controllable upstream returning HTTP 503, verifying that each handler returns HTTP 502 and preserves the upstream status in its response.

Which issue(s) this PR fixes:

Fixes #173

Special notes for your reviewer:

Validation:

go test ./handlers

Does this PR introduce a user-facing change?:

Bug fix: report failed upstream API responses from the counter web UI.

@kubeedge-bot kubeedge-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Aug 14, 2026
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: blackdragoon26
To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed.
You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2026
@blackdragoon26
blackdragoon26 marked this pull request as ready for review August 14, 2026 11:50
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2026
Signed-off-by: Sankalp Jha <sankalp.jha9643@gmail.com>
@blackdragoon26
blackdragoon26 force-pushed the fix/counter-web-upstream-status branch from bac6a40 to 295c8f9 Compare August 14, 2026 11:55
@blackdragoon26

Copy link
Copy Markdown
Author

@kevin-wangzefeng @Catherine-monk
Kindly review my PR.

@kubeedge-bot kubeedge-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2026
Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
@blackdragoon26
blackdragoon26 force-pushed the fix/counter-web-upstream-status branch from d427a9e to 1ff7c2d Compare August 24, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new-counter-demo web UI reports success for failed KubeEdge API responses

2 participants