validate new-counter-demo OTLP endpoint URL - #176
Open
blackdragoon26 wants to merge 2 commits into
Open
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blackdragoon26 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
blackdragoon26
marked this pull request as ready for review
August 14, 2026 11:49
Signed-off-by: Sankalp Jha <sankalp.jha9643@gmail.com>
blackdragoon26
force-pushed
the
fix/counter-otel-endpoint-validation
branch
from
August 14, 2026 11:55
ef42349 to
05bfaa8
Compare
Author
|
@kevin-wangzefeng @wbc6080 |
Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
blackdragoon26
force-pushed
the
fix/counter-otel-endpoint-validation
branch
from
August 24, 2026 14:11
f0a6750 to
5d7fc46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Validates the new-counter-demo OTLP
endpointURLconfiguration as an absolute HTTP or HTTPS URL before provider initialization. Invalid endpoint values now fail with a clear configuration error. A focused regression test covers invalid and valid endpoints.Which issue(s) this PR fixes:
Fixes #175
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: