Skip to content

validate new-counter-demo OTLP endpoint URL - #176

Open
blackdragoon26 wants to merge 2 commits into
kubeedge:masterfrom
blackdragoon26:fix/counter-otel-endpoint-validation
Open

validate new-counter-demo OTLP endpoint URL#176
blackdragoon26 wants to merge 2 commits into
kubeedge:masterfrom
blackdragoon26:fix/counter-otel-endpoint-validation

Conversation

@blackdragoon26

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

Validates the new-counter-demo OTLP endpointURL configuration as an absolute HTTP or HTTPS URL before provider initialization. Invalid endpoint values now fail with a clear configuration error. A focused regression test covers invalid and valid endpoints.

Which issue(s) this PR fixes:

Fixes #175

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?:

Bug fix: validate OTLP endpoint URL configuration before provider initialization.

@kubeedge-bot kubeedge-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Aug 14, 2026
@kubeedge-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: blackdragoon26
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 14, 2026
@blackdragoon26
blackdragoon26 marked this pull request as ready for review August 14, 2026 11:49
@kubeedge-bot kubeedge-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2026
Signed-off-by: Sankalp Jha <sankalp.jha9643@gmail.com>
@blackdragoon26
blackdragoon26 force-pushed the fix/counter-otel-endpoint-validation branch from ef42349 to 05bfaa8 Compare August 14, 2026 11:55
@blackdragoon26

Copy link
Copy Markdown
Author

@kevin-wangzefeng @wbc6080
Kindly review my PR.

Signed-off-by: blackdragoon26 <sankalp.jha9643@gmail.com>
@blackdragoon26
blackdragoon26 force-pushed the fix/counter-otel-endpoint-validation branch from f0a6750 to 5d7fc46 Compare August 24, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new-counter-demo OTLP push accepts invalid endpoint URLs

2 participants