Carry LicenseInfo and TenantInfo through the vendored kmodules libs - #447
Merged
Merged
Conversation
The identity client already unmarshals b3's whole response into ClusterMetadata and UpsertClusterMetadata already persists it, so LicenseInfo reaches ace-info and ClusterIdentity with no handler change; only the libs needed to know the field. The signed ace-info payload changes, which is why this ships with the kmodules bump rather than ahead of it. Vendored kmodules.xyz sources are hand-patched to the unreleased types; the real bump lands when client-go and resource-metadata are tagged. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com> Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
arnob-org-license
branch
from
September 16, 2026 09:32
33784b3 to
649d8ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the org-based licensing track (
arnob-org-licenseinkmodules.xyz/client-go,kmodules.xyz/resource-metadata,go.bytebuilders.dev/audit,go.bytebuilders.dev/license-proxyserver,appscode-cloud/b3).No handler change was needed.
identity.Identifyalready unmarshals b3's whole response intokmapi.ClusterMetadata,UpsertClusterMetadataalready persists it, andClusterIdentity.StatusisClusterMetadata— soLicenseInforeacheskube-public/ace-infoand theclusteridentitiesAPI once the libraries know the field. Nothing outsidevendor/rebuildsClusterMetadatafield-by-field, so no path drops it.This must ship together with the
client-gobump: addingLicensechanges the HMAC-signedace-infopayload. An all-emptyLicenseInfosigns as absent, so ConfigMaps written before this change keep verifying against the new library.Vendored
kmodules.xyzsources are hand-patched to the unreleased types, matching whatauditandlicense-proxyserveralready carry.go.mod/go.sumare untouched; the real bump lands whenclient-goandresource-metadataare tagged.go build ./...passes.