feat: add kube-api-linter checker by dongjiang1989 · Pull Request #421 · kubernetes-sigs/agent-sandbox

dongjiang1989 · 2026-03-16T08:25:54Z

Add kube-api-linter: https://github.com/kubernetes-sigs/kube-api-linter

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

netlify · 2026-03-16T08:26:00Z

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	`be20b18`
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/69bb4feaa2060a00081e855b

dev/tools/.golangci-kal.yml

.github/workflows/presubmit-tests.yml

dev/tools/build-kal

dev/tools/lint-api

Makefile

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

yongruilin

As the contributor of kube-api-linter, I'm happy to see this integration.
Left some comments for better integration and consistency.

extensions/api/v1alpha1/sandboxclaim_types.go

.github/workflows/presubmit-tests.yml

dev/tools/build-kal

dev/tools/lint-api

Co-authored-by: Yongrui Lin <yongrlin@google.com>

.github/workflows/presubmit-tests.yml

dev/tools/.golangci-kal.yml

.github/workflows/presubmit-tests.yml

dev/tools/build-kal

dev/tools/.golangci-kal.yml

extensions/api/v1alpha1/sandboxclaim_types.go

.github/workflows/presubmit-tests.yml

extensions/api/v1alpha1/sandboxclaim_types.go

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

dongjiang1989 · 2026-03-18T01:42:04Z

TOOD: Add presubmit-agent-sandbox-lint-api in test-infra. @dongjiang1989

yongruilin

The current PR doesn't cover the api/v1alpha1/ . I think there should be lint issues need to be addressed in sandbox_types.go as well.
You can apply my suggested change to .golangci-kal.yml and run make lint-api to reveal the issues.

yongruilin · 2026-03-18T06:47:30Z

dev/tools/.golangci-kal.yml

+    - path-except: api/.*
+      linters:
+        - kubeapilinter
+    - path-except: extensions/api/.*
+      linters:
+        - kubeapilinter


Suggested change

- path-except: api/.*

linters:

- kubeapilinter

- path-except: extensions/api/.*

linters:

- kubeapilinter

- path-except: "api/.*"

linters:

- kubeapilinter

The two separate path-except rules mean an issue is excluded if it matches either rule. Files under api/v1alpha1/ pass rule 1 but get excluded by rule 2. So KAL only runs on extensions/api/, missing all issues in core api/.
Actually, a single rule is enough to cover both paths.

@yongruilin Thanks 🙏
U are right!
Updated!

This maybe rule check bug?

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

yongruilin

one nit, then LGTM

dev/ci/presubmits/lint-go

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

yongruilin

/lgtm

Thanks!
@janetkuo for API doc change

janetkuo

/lgtm

k8s-ci-robot · 2026-03-19T03:12:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [janetkuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* add kube-api-linter checker Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix by codereview Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * rm no use file Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * revert dev/ci/presubmits/lint-go Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * update chmod 755 Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * Update dev/tools/lint-api Co-authored-by: Yongrui Lin <yongrlin@google.com> * Update extensions/api/v1alpha1/sandboxclaim_types.go * fix lint-api Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * update by codereview Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * update make gen Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * revert nit Signed-off-by: dongjiang1989 <dongjiang1989@126.com> --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com> Co-authored-by: Yongrui Lin <yongrlin@google.com>

add kube-api-linter checker

2c21f69

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

k8s-ci-robot requested review from justinsb and soltysh March 16, 2026 08:26

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 16, 2026

aditya-shantanu reviewed Mar 16, 2026

View reviewed changes

dongjiang1989 added 4 commits March 17, 2026 11:09

fix by codereview

d6e67d4

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

rm no use file

31ad777

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

revert dev/ci/presubmits/lint-go

e07d414

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

update chmod 755

63fe46d

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

yongruilin reviewed Mar 17, 2026

View reviewed changes

extensions/api/v1alpha1/sandboxclaim_types.go Show resolved Hide resolved

.github/workflows/presubmit-tests.yml Outdated Show resolved Hide resolved

dev/tools/build-kal Show resolved Hide resolved

dev/tools/lint-api Outdated Show resolved Hide resolved

Update dev/tools/lint-api

b0c37dd

Co-authored-by: Yongrui Lin <yongrlin@google.com>

dongjiang1989 commented Mar 18, 2026

View reviewed changes

dongjiang1989 and others added 2 commits March 18, 2026 09:11

Update extensions/api/v1alpha1/sandboxclaim_types.go

7a88fae

fix lint-api

66b3b7d

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

yongruilin reviewed Mar 18, 2026

View reviewed changes

dongjiang1989 added 2 commits March 18, 2026 16:10

update by codereview

9616cf1

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

update make gen

ec6cfc3

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

yongruilin reviewed Mar 18, 2026

View reviewed changes

dev/ci/presubmits/lint-go Outdated Show resolved Hide resolved

revert nit

be20b18

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

yongruilin reviewed Mar 19, 2026

View reviewed changes

k8s-ci-robot assigned yongruilin Mar 19, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2026

janetkuo approved these changes Mar 19, 2026

View reviewed changes

k8s-ci-robot assigned janetkuo Mar 19, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2026

k8s-ci-robot merged commit 62cce73 into kubernetes-sigs:main Mar 19, 2026
10 checks passed

dongjiang1989 deleted the add-kube-api-linter branch March 19, 2026 04:33

dongjiang1989 mentioned this pull request Mar 19, 2026

feat: add kube api linter in presubmits in agent-sandbox kubernetes/test-infra#36685

Merged

dongjiang1989 mentioned this pull request Mar 21, 2026

Change(crd): rename 'Name' to 'name' in sandboxclaim_types CRD #440

Merged

Conversation

dongjiang1989 commented Mar 16, 2026

Uh oh!

netlify bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for agent-sandbox canceled.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yongruilin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dongjiang1989 commented Mar 18, 2026

Uh oh!

yongruilin left a comment

Choose a reason for hiding this comment

Uh oh!

yongruilin Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

dongjiang1989 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

dongjiang1989 Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

yongruilin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yongruilin left a comment

Choose a reason for hiding this comment

Uh oh!

janetkuo left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify bot commented Mar 16, 2026 •

edited

Loading

yongruilin left a comment •

edited

Loading