Add ServiceGatewayClient to Azure client factory#10066
Add ServiceGatewayClient to Azure client factory#10066georgeedward2000 wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: georgeedward2000 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @georgeedward2000. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
- Introduced ServiceGatewayClient interface and implementation for managing Azure Service Gateways. - Updated ClientFactory interface to include GetServiceGatewayClient method. - Implemented ServiceGatewayClient methods for creating, updating, deleting, and listing Service Gateways. - Added tests for ServiceGatewayClient to ensure functionality and error handling. - Integrated metrics and tracing for ServiceGateway operations.
0a03630 to
bccd83e
Compare
|
/ok-to-test |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Introduces a new
ServiceGatewayClientinpkg/azclient/for managing Azure Service Gateway resources viaarmnetwork/v9.ServiceGatewayClientinterface and implementation for managing Azure Service GatewaysClientFactoryinterface to includeGetServiceGatewayClient()methodUpdateTags,GetAddressLocations,GetServices,UpdateAddressLocations,UpdateServicesServiceGatewayClientserviceGatewayRateLimitconfig keyWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The custom methods follow established patterns in the codebase:
UpdateTags— non-LRO, followsvirtualnetworkclient/custom.gopatternGetAddressLocations/GetServices— pager-based, followsinterfaceclient/custom.gopatternUpdateAddressLocations/UpdateServices— LRO-based, followsprivatelinkserviceclient/custom.gopatternThe generated integration tests (
servicegatewayclient_test.go) require Azure credentials and a recorded cassette to pass locally — this is expected for all newly generated clients.Does this PR introduce a user-facing change?