Skip to content

chore: remove deprecated rand.Seed#10142

Open
YurDuiachenko wants to merge 1 commit intokubernetes-sigs:masterfrom
YurDuiachenko:cleanup/remove-deprecated-rand-seed
Open

chore: remove deprecated rand.Seed#10142
YurDuiachenko wants to merge 1 commit intokubernetes-sigs:masterfrom
YurDuiachenko:cleanup/remove-deprecated-rand-seed

Conversation

@YurDuiachenko
Copy link
Copy Markdown

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes the deprecated top-level rand.Seed call from cloud-controller-manager and node-manager startup.

The project builds with a modern Go version, where the global math/rand generator is already auto-seeded, so the explicit rand.Seed(...) call is no longer needed.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

This is a cleanup-only change and does not change runtime behavior.
rand.Float64() is still used for resync jitter and continues to work as expected without an explicit seed.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YurDuiachenko
Once this PR has been reviewed and has the lgtm label, please assign nilo19 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cheftako and nilo19 April 4, 2026 09:23
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @YurDuiachenko. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2026
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 4, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2026
@YurDuiachenko
Copy link
Copy Markdown
Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 4, 2026
@YurDuiachenko
Copy link
Copy Markdown
Author

/assign nilo19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants