🐛 Changed DHA to require hostAffinity to be host to prevent instance drift#5910
🐛 Changed DHA to require hostAffinity to be host to prevent instance drift#5910vr4manta wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @vr4manta. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
LGTM label has been added. DetailsGit tree hash: adfa3c26b2cf8239144ea8e2b5423f601ac45480 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently if you use dynamic host allocation (DHA) to create an awsmachine and allocate a host, the instance can drift off that host if it is configured with anything but
hostAffinity=host. This PR is intended to make sure we requirehostAffinity=hostwhen configuring DHAWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: