🐛 Fix AWS SDK request metrics not being captured#5924
Open
AndiDog wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
🐛 Fix AWS SDK request metrics not being captured#5924AndiDog wants to merge 1 commit intokubernetes-sigs:mainfrom
AndiDog wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Also, since these "v2" metrics have never worked, I'm removing the suffix from metric names so users don't have to adapt their queries.
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-priority
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The diff explains the bug 😉 – we had inverted logic and excluded all metrics. Tested locally with Tilt and curl-ing the metrics endpoint.
Since these "v2" metrics have never worked, I'm also removing the suffix from metric names so users don't have to adapt their queries.
Checklist:
Release note: