Skip to content

🐛 Only apply new or changed tags to EC2 and EKS objects#5926

Open
AndiDog wants to merge 1 commit intokubernetes-sigs:mainfrom
AndiDog:apply-tags-diff
Open

🐛 Only apply new or changed tags to EC2 and EKS objects#5926
AndiDog wants to merge 1 commit intokubernetes-sigs:mainfrom
AndiDog:apply-tags-diff

Conversation

@AndiDog
Copy link
Copy Markdown
Contributor

@AndiDog AndiDog commented Apr 2, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

When creating or updating tags, CAPA currently sends all tags including unchanged ones. That can lead to alert of scanning tools if they forbid a certain tag from being modified, or IAM policies may deny such changes directly. By sending only the new or changed tags (here, CAPA doesn't delete tags, by the way), this can be avoided and requests become smaller. I've also added a test for the actual AWS API calls because we didn't have that behavior covered yet.

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Only apply new or changed tags to EC2 and EKS objects

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-priority labels Apr 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from dlipovetsky April 2, 2026 14:03
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from fiunchinho April 2, 2026 14:03
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@AndiDog: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-test 25a4781 link true /test pull-cluster-api-provider-aws-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants