🐛 Only apply new or changed tags to EC2 and EKS objects#5926
🐛 Only apply new or changed tags to EC2 and EKS objects#5926AndiDog wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@AndiDog: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When creating or updating tags, CAPA currently sends all tags including unchanged ones. That can lead to alert of scanning tools if they forbid a certain tag from being modified, or IAM policies may deny such changes directly. By sending only the new or changed tags (here, CAPA doesn't delete tags, by the way), this can be avoided and requests become smaller. I've also added a test for the actual AWS API calls because we didn't have that behavior covered yet.
Checklist:
Release note: