✨ Add AWS Nitro Enclave support to AWSLaunchTemplate#5928
✨ Add AWS Nitro Enclave support to AWSLaunchTemplate#5928raykrueger wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @raykrueger! |
|
Hi @raykrueger. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d734ce3 to
ce8b99b
Compare
Adds enclaveOptions field to AWSLaunchTemplate, wiring it through the launch template data builder, SDK reverse-mapping, update detection, and v1beta1 annotation-based conversion restore. Includes unit tests and documentation.
ce8b99b to
08cbdb9
Compare
What type of PR is this?
/kind api-change
What this PR does / why we need it:
AWSLaunchTemplatedoes not exposeEnclaveOptions, preventing CAPA users from enabling AWS Nitro Enclaves on managed machine pool nodes. The field is available in the EC2 launch template API but was never wired into the CAPA types or launch template builder.This adds an
EnclaveOptionsstruct toapi/v1beta2and a corresponding field onAWSLaunchTemplate, mapped throughcreateLaunchTemplateData(),SDKToLaunchTemplate(), andLaunchTemplateNeedsUpdate()— following the same pattern asInstanceMetadataOptions. Nitro Enclaves were called out as a motivating example in the original launch template proposal (docs/proposal/20211210-launch-templates-managedmachinepools.md).Which issue(s) this PR fixes:
Fixes #5927
Special notes for your reviewer:
EnclaveOptionsis a v1beta2-only field. The annotation-based restore pattern inexp/api/v1beta1/conversion.gohas been updated for bothAWSMachinePoolandAWSManagedMachinePool, following the same approach asInstanceMetadataOptions,PrivateDNSName, and other v1beta2-onlyAWSLaunchTemplatefields.This PR was developed with AI and my direct supervision.
Checklist:
Release note: