WIP: [IGNORE] Dual-write v1beta2 initialization and conditions in controllers#6202
WIP: [IGNORE] Dual-write v1beta2 initialization and conditions in controllers#6202willie-yao wants to merge 4 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: William Yao <william2000yao@gmail.com>
Signed-off-by: William Yao <william2000yao@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6202 +/- ##
==========================================
- Coverage 43.67% 43.42% -0.25%
==========================================
Files 289 289
Lines 25495 25664 +169
==========================================
+ Hits 11134 11145 +11
- Misses 13559 13717 +158
Partials 802 802 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: William Yao <william2000yao@gmail.com>
8a65e2e to
65bca2f
Compare
|
/test ls |
|
/test pull-cluster-api-provider-azure-e2e-kuberay |
Signed-off-by: William Yao <william2000yao@gmail.com>
|
/test pull-cluster-api-provider-azure-capi-e2e |
|
@willie-yao: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Future follow-up on #6199
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Implementation notes:
Initialization: Every place that sets status.ready = true/false now also sets status.initialization.provisioned (or status.initialization.controlPlaneInitialized for control plane types).
Conditions: Each scope's PatchObject() method now mirrors the existing v1beta1 Ready summary condition into status.v1beta2.conditions as a metav1.Condition of type Ready (plus Available for AzureManagedControlPlane, per the ControlPlane contract). The patch helper declares these as owned v1beta2 conditions via WithOwnedV1Beta2Conditions.
TODOs:
Release note: