Skip to content

WIP: [IGNORE] Dual-write v1beta2 initialization and conditions in controllers#6202

Draft
willie-yao wants to merge 4 commits intokubernetes-sigs:mainfrom
willie-yao:v1beta2-write-fields
Draft

WIP: [IGNORE] Dual-write v1beta2 initialization and conditions in controllers#6202
willie-yao wants to merge 4 commits intokubernetes-sigs:mainfrom
willie-yao:v1beta2-write-fields

Conversation

@willie-yao
Copy link
Copy Markdown
Contributor

@willie-yao willie-yao commented Apr 3, 2026

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Future follow-up on #6199

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Implementation notes:
Initialization: Every place that sets status.ready = true/false now also sets status.initialization.provisioned (or status.initialization.controlPlaneInitialized for control plane types).

Conditions: Each scope's PatchObject() method now mirrors the existing v1beta1 Ready summary condition into status.v1beta2.conditions as a metav1.Condition of type Ready (plus Available for AzureManagedControlPlane, per the ControlPlane contract). The patch helper declares these as owned v1beta2 conditions via WithOwnedV1Beta2Conditions.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Dual-write v1beta2 initialization and conditions in controllers

Signed-off-by: William Yao <william2000yao@gmail.com>
Signed-off-by: William Yao <william2000yao@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Apr 3, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackfrancis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 6.52174% with 172 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.42%. Comparing base (4c5753c) to head (5e2c8a6).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
azure/scope/managedcontrolplane.go 0.00% 24 Missing ⚠️
azure/scope/machine.go 0.00% 20 Missing ⚠️
azure/scope/machinepool.go 10.00% 18 Missing ⚠️
azure/scope/machinepoolmachine.go 5.26% 18 Missing ⚠️
azure/scope/managedmachinepool.go 0.00% 17 Missing ⚠️
azure/scope/cluster.go 0.00% 16 Missing ⚠️
api/v1beta1/azurecluster_types.go 0.00% 8 Missing ⚠️
api/v1beta1/azureclusteridentity_types.go 0.00% 8 Missing ⚠️
api/v1beta1/azuremachine_types.go 0.00% 8 Missing ⚠️
api/v1beta1/azuremanagedcontrolplane_types.go 0.00% 8 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6202      +/-   ##
==========================================
- Coverage   43.67%   43.42%   -0.25%     
==========================================
  Files         289      289              
  Lines       25495    25664     +169     
==========================================
+ Hits        11134    11145      +11     
- Misses      13559    13717     +158     
  Partials      802      802              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: William Yao <william2000yao@gmail.com>
@willie-yao willie-yao force-pushed the v1beta2-write-fields branch from 8a65e2e to 65bca2f Compare April 3, 2026 19:49
@willie-yao
Copy link
Copy Markdown
Contributor Author

/test ls

@willie-yao
Copy link
Copy Markdown
Contributor Author

/test pull-cluster-api-provider-azure-e2e-kuberay
/test pull-cluster-api-provider-azure-e2e-optional
/test pull-cluster-api-provider-azure-apiserver-ilb
/test pull-cluster-api-provider-azure-capi-e2e
/test pull-cluster-api-provider-azure-conformance
/test pull-cluster-api-provider-azure-conformance-custom-builds

Signed-off-by: William Yao <william2000yao@gmail.com>
@willie-yao
Copy link
Copy Markdown
Contributor Author

/test pull-cluster-api-provider-azure-capi-e2e
/test pull-cluster-api-provider-azure-e2e-optional

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@willie-yao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e 5e2c8a6 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-apiversion-upgrade 5e2c8a6 link true /test pull-cluster-api-provider-azure-apiversion-upgrade
pull-cluster-api-provider-azure-capi-e2e 5e2c8a6 link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-e2e-optional 5e2c8a6 link false /test pull-cluster-api-provider-azure-e2e-optional
pull-cluster-api-provider-azure-ci-entrypoint 5e2c8a6 link true /test pull-cluster-api-provider-azure-ci-entrypoint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@willie-yao willie-yao marked this pull request as draft April 6, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants