critest: test metric descriptors#2017
Open
dgrisonnet wants to merge 2 commits intokubernetes-sigs:masterfrom
Open
critest: test metric descriptors#2017dgrisonnet wants to merge 2 commits intokubernetes-sigs:masterfrom
dgrisonnet wants to merge 2 commits intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dgrisonnet The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
dgrisonnet
force-pushed
the
test-metrics-desc
branch
from
c0faba6 to
b16fe01
Compare
Signed-off-by: Peter Hunt <pehunt@redhat.com> critest: drop cpuLoad metrics from test some context: kubernetes/kubernetes#134981 Signed-off-by: Peter Hunt <pehunt@redhat.com> critest/metrics: generate some disk usage to guarantee io metrics are present Signed-off-by: Peter Hunt <pehunt@redhat.com> crio: update config to enable metrics Signed-off-by: Peter Hunt <pehunt@redhat.com>
dgrisonnet
force-pushed
the
test-metrics-desc
branch
5 times, most recently
from
57d93d6 to
22a6b74
Compare
Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
dgrisonnet
force-pushed
the
test-metrics-desc
branch
from
22a6b74 to
10c0ca7
Compare
| for _, desc := range descs { | ||
| if len(metricNamesFound[desc.GetName()]) != len(desc.GetLabelKeys()) { | ||
| if slices.Contains(optionalValuesForMetricDescriptors, desc.GetName()) { | ||
| continue // skip optional values |
Contributor
There was a problem hiding this comment.
I'm not sure this check actually checks the right thing. We maybbe should svae the ones not present, and fail if any not in optionalValuesForMetricDescriptors arent. for instance:
name: ["container_fs_reads_bytes_total", "other"]
GetLabelKeys: []
would pass here, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is built on top of #1931 with an updated list of expected metrics descriptors for Kubernetes 1.37
Which issue(s) this PR fixes:
Special notes for your reviewer:
I included PSI metrics since the feature is in Beta, enabled by default and I think it is better to validate here before the feature becomes stable.
Does this PR introduce a user-facing change?