fix(helm): missing quotes on container arguments#6264
fix(helm): missing quotes on container arguments#6264KhooHaoYit wants to merge 2 commits intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @KhooHaoYit! |
|
Hi @KhooHaoYit. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Pull Request Test Coverage Report for Build 23092761733Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@KhooHaoYit Do you think you can also update the |
|
@mloiseleur I have updated |
What does it do ?
Ensures that the value being passed to the container arguments are strings
Motivation
I had encountered issue where it was formatted as a number while trying to pass the value into the container arguments
More