Skip to content

fix(helm): missing quotes on container arguments#6264

Open
KhooHaoYit wants to merge 2 commits intokubernetes-sigs:masterfrom
KhooHaoYit:master
Open

fix(helm): missing quotes on container arguments#6264
KhooHaoYit wants to merge 2 commits intokubernetes-sigs:masterfrom
KhooHaoYit:master

Conversation

@KhooHaoYit
Copy link
Copy Markdown

What does it do ?

Ensures that the value being passed to the container arguments are strings

Motivation

I had encountered issue where it was formatted as a number while trying to pass the value into the container arguments

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stevehipwell for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @KhooHaoYit!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @KhooHaoYit. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2026
@vflaux
Copy link
Copy Markdown
Contributor

vflaux commented Mar 11, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 11, 2026

Pull Request Test Coverage Report for Build 23092761733

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 192 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.5%) to 79.654%

Files with Coverage Reduction New Missed Lines %
apis/externaldns/types.go 1 99.63%
endpoints.go 2 90.48%
utils.go 3 96.34%
service.go 8 94.05%
cloudflare/cloudflare.go 15 96.85%
testutils/endpoint.go 16 71.29%
execute.go 22 59.71%
pdns/pdns.go 45 72.9%
store.go 80 49.86%
Totals Coverage Status
Change from base Build 22942394534: 0.5%
Covered Lines: 16572
Relevant Lines: 20805

💛 - Coveralls

@mloiseleur
Copy link
Copy Markdown
Collaborator

@KhooHaoYit Do you think you can also update the CHANGELOG.md, accordingly?

@KhooHaoYit
Copy link
Copy Markdown
Author

@mloiseleur I have updated CHANGELOG.md accordingly

Copy link
Copy Markdown
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2026
@vflaux vflaux mentioned this pull request Apr 6, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants