feat(powerdns): add LUA record support#6317
feat(powerdns): add LUA record support#6317minimalmattt wants to merge 6 commits intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @minimalmattt! |
|
Hi @minimalmattt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I'm not sure we want to add non‑standard record types into the core code. Cloudflare proxied records and AWS alias records are implemented through provider‑specific properties as well, but those remain standard A/AAAA/CNAME record types, unlike the LUA type from PowerDNS. I’d like to get the maintainers’ opinion on this. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I strongly agree with your comment, @vflaux. This provider specific feature should not go into core code. |
|
HI, thanks for the feedback. |
|
@minimalmattt We have started an effort to move providers out of tree (#4347). You can make your own for powerdns and include this with a provider-specific. |
What does it do ?
This PR adds support for the LUA record type (Exclusive to PowerDNS)
Motivation
PowerDNS supports a LUA record type (https://doc.powerdns.com/authoritative/lua-records/index.html)
It's akin to a TXT record in the fact that by itself it only stores a lua snippet in the form of text, but it is parsed differently by PowerDNS, actually executing the provided script and using the return value as the answer.
More
This feature is gated behind the "managed-record-types" argument so it's not enabled by default.
I tested this on k8s 1.32, external-dns v0.20 and powerDNS 4.8.3