Skip to content

[feat] Latency Prediction CI tests#2651

Closed
Gregory-Pereira wants to merge 1 commit intokubernetes-sigs:mainfrom
Gregory-Pereira:latencyprediction-ci-test
Closed

[feat] Latency Prediction CI tests#2651
Gregory-Pereira wants to merge 1 commit intokubernetes-sigs:mainfrom
Gregory-Pereira:latencyprediction-ci-test

Conversation

@Gregory-Pereira
Copy link
Copy Markdown
Member

@Gregory-Pereira Gregory-Pereira commented Mar 20, 2026

What type of PR is this?
Add one of the following kinds:
/kind feature
/area conformance-test

What this PR does / why we need it:

Functional / regression testing for latency prediction. Provides maintainers more clarity about if a change is affecting the codebase.

How it works:
On open PRs that modify the latencyprediction directory it will rebuild the images, tag them both by sha- and tag them by pr number. It will push those ephemeral images to this repo's package registry in ghcr.io (open to alternatives here, I know y'all do something else with prow for on push builds). Then it patches the new images into the kustomization.yaml. It will then roll our functional tests with these new images.

Important Technical Detail
After running these tests a bunch of times, I realized when you deploy the job at the same time as prediction and training servers, it will automatically skip every fixture in the job, which will show up as a pass. Instead we need to rollout the prediction and training servers, waiting for them to come online, before creating our test job.

Why only run this on open PRs and not on pushes to main (merged work)?
This is because the cloudbuild.yaml will already build images for every push to main - so if we want to test merged work too we should refactor this to a workflow call.

Does this PR introduce a user-facing change?:
No user facing changes

cc @kaushikmitr @kfswain

Signed-off-by: greg pereira <grpereir@redhat.com>
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. area/conformance-test Issues or PRs related to Conformance tests. labels Mar 20, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 20, 2026

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 29153fb
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69bdd4adcca83400074082df
😎 Deploy Preview https://deploy-preview-2651--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2026
@kaushikmitr
Copy link
Copy Markdown
Contributor

this looks good to me. will catch regressions in the latencypredictor python module. @Gregory-Pereira is this WIP?

@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Apr 17, 2026

needs to be opened against the llm-d repo after the move.

@ahg-g ahg-g closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants