Skip to content

Generalize request type: Move RequestBody from scheduling to requesthandling#2808

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
RyanRosario:pr/issue-2447-second
Apr 10, 2026
Merged

Generalize request type: Move RequestBody from scheduling to requesthandling#2808
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
RyanRosario:pr/issue-2447-second

Conversation

@RyanRosario
Copy link
Copy Markdown
Contributor

@RyanRosario RyanRosario commented Apr 8, 2026 •
edited
Loading

/cleanup

What this PR does / why we need it:
This is part of a larger refactor that allows the use of pluggable parsers.

Which issue(s) this PR fixes:
Part of #2447

Does this PR introduce a user-facing change?:

NONE

Built from 2808

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 8, 2026 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 2769bb3
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/69d9651683f19d00083da5c7
😎 Deploy Preview https://deploy-preview-2808--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 8, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 8, 2026

Hi @RyanRosario. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2026
@zetxqx
Copy link
Copy Markdown
Contributor

zetxqx commented Apr 8, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2026
@zetxqx zetxqx mentioned this pull request Apr 8, 2026
Closed
@RyanRosario RyanRosario force-pushed the pr/issue-2447-second branch from 6d122e2 to 8629abd Compare April 8, 2026 18:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2026
@RyanRosario RyanRosario force-pushed the pr/issue-2447-second branch 2 times, most recently from 9a49201 to d7eb204 Compare April 8, 2026 19:00
@RyanRosario
Copy link
Copy Markdown
Contributor Author

RyanRosario commented Apr 8, 2026

@ahg-g Please review when you get a chance.

@RyanRosario RyanRosario force-pushed the pr/issue-2447-second branch from d7eb204 to 8c2d3d4 Compare April 8, 2026 19:46
@zetxqx zetxqx mentioned this pull request Apr 8, 2026
Merged
zetxqx
zetxqx reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zetxqx zetxqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one super nit comment on the import alias

Comment thread ...pp/framework/plugins/requestcontrol/requestdataproducer/inflightload/token_estimator_test.go Outdated
Comment thread pkg/epp/framework/plugins/requestcontrol/requestdataproducer/inflightload/producer_test.go Outdated
Comment thread pkg/epp/framework/interface/scheduling/types.go Outdated
Comment thread pkg/epp/framework/interface/requestcontrol/types.go Outdated
@zetxqx zetxqx mentioned this pull request Apr 8, 2026
Merged
@RyanRosario RyanRosario force-pushed the pr/issue-2447-second branch 3 times, most recently from 03fef64 to 3865607 Compare April 9, 2026 20:24
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2026
@RyanRosario RyanRosario force-pushed the pr/issue-2447-second branch from 3865607 to a592f62 Compare April 9, 2026 20:41
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2026
zetxqx
zetxqx reviewed Apr 9, 2026
View reviewed changes
Comment thread pkg/epp/framework/interface/scheduling/types_test.go Outdated
Copy link
Copy Markdown
Contributor

@zetxqx zetxqx Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are moved to requesthandling. so we should delete it

@zetxqx
Copy link
Copy Markdown
Contributor

zetxqx commented Apr 9, 2026

a592f62 mostly looks good. just some import alias should be better to use fwkrh and the scheduling/type_test.go should be removed.

@RyanRosario
Copy link
Copy Markdown
Contributor Author

RyanRosario commented Apr 10, 2026

@zetxqx These were fixed in PR3 as that is when they became evident. I will fix them in PR2.

@RyanRosario RyanRosario force-pushed the pr/issue-2447-second branch 3 times, most recently from b2f7b66 to 56cbdaa Compare April 10, 2026 08:37
@zetxqx
Copy link
Copy Markdown
Contributor

zetxqx commented Apr 10, 2026

56cbdaa looks good to me!

@RyanRosario RyanRosario force-pushed the pr/issue-2447-second branch from 56cbdaa to 2769bb3 Compare April 10, 2026 21:01
@ahg-g
Copy link
Copy Markdown
Contributor

ahg-g commented Apr 10, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, RyanRosario

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026
@k8s-ci-robot k8s-ci-robot merged commit 4372ace into kubernetes-sigs:main Apr 10, 2026
11 checks passed
elevran pushed a commit to llm-d/llm-d-inference-scheduler that referenced this pull request Apr 23, 2026
@RyanRosario
Move RequestBody from scheduling to requesthandling (kubernetes-sigs/…
7548a52 
…gateway-api-inference-extension#2808)

Co-authored-by: Ryan Rosario <6713180+RyanRosario@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

@robscott robscott Awaiting requested review from robscott

1 more reviewer

@zetxqx zetxqx zetxqx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ahg-g ahg-g

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RyanRosario @k8s-ci-robot @zetxqx @ahg-g