fix(disruption): correctly accumulate pod-count in LogValues#2913
fix(disruption): correctly accumulate pod-count in LogValues#2913J926L wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
The lo.Reduce function was discarding the accumulator, resulting in only the last candidate's pod count being logged. This change ensures the pod counts from all candidates are correctly summed.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: J926L The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @J926L! |
|
Hi @J926L. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Closing in favor of #2912 |
The lo.Reduce function in Command.LogValues was incorrectly discarding the accumulator, leading to inaccurate pod counts in logs. This PR fixes the reduction logic and adds a comprehensive test suite to verify correct accumulation across multiple candidates.