Skip to content

fix(disruption): correctly accumulate pod-count in LogValues#2913

Closed
J926L wants to merge 1 commit intokubernetes-sigs:mainfrom
J926L:fix/lo-reduce-podcount
Closed

fix(disruption): correctly accumulate pod-count in LogValues#2913
J926L wants to merge 1 commit intokubernetes-sigs:mainfrom
J926L:fix/lo-reduce-podcount

Conversation

@J926L
Copy link
Copy Markdown

@J926L J926L commented Mar 17, 2026

The lo.Reduce function in Command.LogValues was incorrectly discarding the accumulator, leading to inaccurate pod counts in logs. This PR fixes the reduction logic and adds a comprehensive test suite to verify correct accumulation across multiple candidates.

The lo.Reduce function was discarding the accumulator, resulting in only the last candidate's pod count being logged. This change ensures the pod counts from all candidates are correctly summed.
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Not Signed

@k8s-ci-robot k8s-ci-robot requested review from njtran and tallaxes March 17, 2026 05:52
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: J926L
Once this PR has been reviewed and has the lgtm label, please assign maciekpytel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @J926L!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @J926L. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2026
J926L added a commit to J926L/J926L that referenced this pull request Mar 17, 2026
@jmdeal
Copy link
Copy Markdown
Member

jmdeal commented Apr 20, 2026

Closing in favor of #2912

@jmdeal jmdeal closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants