Align AccessPolicy condition comments and constants with Gateway API#232
Align AccessPolicy condition comments and constants with Gateway API#232haiyanmeng wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
- Update comments for `PolicyConditionAccepted` in `accesspolicy_types.go` to explicitly list valid reasons for True and False states, matching Gateway API style. - Define `PolicyReasonAccepted` as a `PolicyConditionReason` constant to avoid hardcoding `"Accepted"`. - Update `pkg/controller/accesspolicy.go` and `pkg/translator/common_test.go` to use the new `PolicyReasonAccepted` constant instead of literal strings. - Refine comments for reasons to use "This reason is used..." phrasing.
k8s-ci-robot
added
the
kind/cleanup
✅ Deploy Preview for kube-agentic-networking ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/S
|
/approve /cc @guicassolato for lgtm |
|
@LiorLieberman: GitHub didn't allow me to request PR reviews from the following users: lgtm, for. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haiyanmeng, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
PolicyConditionAcceptedinaccesspolicy_types.goto explicitly list valid reasons for True and False states, matching Gateway API style.PolicyReasonAcceptedas aPolicyConditionReasonconstant to avoid hardcoding"Accepted".pkg/controller/accesspolicy.goandpkg/translator/common_test.goto use the newPolicyReasonAcceptedconstant instead of literal strings.Does this PR introduce a user-facing change?: