-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ feat(alpha/update): add git commands to GH issue description #5466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vitorfloriano
wants to merge
1
commit into
kubernetes-sigs:master
Choose a base branch
from
vitorfloriano:feat-enhance-issue-description-alpha-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−12
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to share something like If you want to run this update manually then use alpha update.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the workflow has already created the updated branch, is it still necessary to run alpha update locally?
Then we would also need to inform users that they need to install the latest binary to do that...
I was also thinking about adding a link to the workflow that created the issue, so users can inspect the logs and understand what happened.
It could be something like this:
Description
Upgrade your project to use the latest scaffold changes introduced in Kubebuilder %[1]s.
See the release notes from %[3]s to %[1]s for details about the changes included in this upgrade.
What to do
A scheduled workflow already attempted this upgrade and created the branch (%[4]s) to help you in this process. You can see the logs from the workflow run in here: %[6]s 👈 ADD THIS
Create a Pull Request using the URL below to review the changes and resolve conflicts manually:👈 REMOVE THIS%[2]s
Next steps
Locate and resolve the merge conflicts.
After fixing conflicts, run:
Optional
If you wish to run this migration locally, please refer to the docs: 👈 ADD THIS TOO
📖 https://kubebuilder.io/reference/commands/alpha_update
WDYT?