-
Notifications
You must be signed in to change notification settings - Fork 74
docs: add Helm installation guide #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tejassinghbhati
wants to merge
8
commits into
kubernetes-sigs:main
Choose a base branch
from
tejassinghbhati:docs/helm-installation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+126
−2
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4ff71b6
docs: add Helm installation guide
tejassinghbhati c844245
docs: add Helm upgrade and custom values to the install guide
tejassinghbhati dddcd94
docs: cover the controller tuning values from #392
tejassinghbhati fd78bdc
docs: follow the chart rename and fix the verification selector
tejassinghbhati 1f075a5
Revert the verification selector change
tejassinghbhati 24eb39d
docs: update Helm install guide to use registry.k8s.io OCI chart
tejassinghbhati 2bf7437
docs: validate the Helm steps against the published 0.5.0 chart
tejassinghbhati e65dc47
docs: trim the Helm section per review
tejassinghbhati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitorfloriano is this because the chart cannot carry the "vX.Y.Z" pattern?
Could you help check if there's room for unifying / fixing this? Having it different would cause discovery issues as we have to keep documenting the mapping in our documentation somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a Helm limitation, I checked. Helm takes v0.5.0 as a chart version fine, it packages, lints and renders, and helm show chart reads it back as v0.5.0.
The v gets dropped by one line in the Makefile:
That came in with #402, so the split is a choice rather than a constraint. Unifying is deleting that sed and setting Chart.yaml to v0.5.0. ct is not in the way either, check-version-increment is already false.
The case for leaving it stripped is that semver itself has no v and most published charts use the plain number, so anything parsing chart versions strictly expects 0.5.0. Helm is lenient, other consumers may not be.
Happy to do it if you want it. It touches the Makefile, Chart.yaml and the version check I added in #453, and it would remove the CHART_VERSION vs VERSION split from these docs, which is the discovery problem you are describing.