Skip to content

infra: remove govulncheck script and GHA workflow #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitorfloriano wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −103
Open

infra: remove govulncheck script and GHA workflow #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions .github/workflows/govulncheck.yml
View file
Open in desktop

This file was deleted.

11 changes: 7 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ CONTROLLER_GEN_BIN := controller-gen
CONTROLLER_GEN := $(abspath $(TOOLS_BIN_DIR)/$(CONTROLLER_GEN_BIN)-$(CONTROLLER_GEN_VER))
CONTROLLER_GEN_PKG := sigs.k8s.io/controller-tools/cmd/controller-gen

GOVULNCHECK_VER := v1.1.4
GOVULNCHECK_VER := v1.7.0
GOVULNCHECK_BIN := govulncheck
GOVULNCHECK := $(abspath $(TOOLS_BIN_DIR)/$(GOVULNCHECK_BIN)-$(GOVULNCHECK_VER))
GOVULNCHECK_PKG := golang.org/x/vuln/cmd/govulncheck
Expand Down Expand Up @@ -178,9 +178,9 @@ lint-api-fix: $(GOLANGCI_LINT_KAL)
lint-config: $(GOLANGCI_LINT) ## Verify golangci-lint linter configuration
$(GOLANGCI_LINT) config verify

.PHONY: govulncheck
govulncheck: $(GOVULNCHECK) ## Run govulncheck to detect known vulnerabilities.
$(GOVULNCHECK) -scan package ./...
.PHONY: verify-govulncheck
verify-govulncheck: $(GOVULNCHECK) ## Run govulncheck verification
$(GOVULNCHECK) -C $(ROOT_DIR) -show verbose ./...

.PHONY: verify
verify: ## Run all verification scripts.
Expand Down Expand Up @@ -449,6 +449,9 @@ $(GOLANGCI_LINT_BIN): $(GOLANGCI_LINT) ## Build a local copy of golangci-lint.
.PHONY: $(KIND_BIN)
$(KIND_BIN): $(KIND) ## Build a local copy of kind.

.PHONY: $(GOVULNCHECK_BIN)
$(GOVULNCHECK_BIN): $(GOVULNCHECK) ## Build a local copy of govulncheck.

$(KUSTOMIZE): # Build kustomize from tools folder.
CGO_ENABLED=0 GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) $(KUSTOMIZE_PKG) $(KUSTOMIZE_BIN) $(KUSTOMIZE_VER)

Expand Down
1 change: 0 additions & 1 deletion hack/verify-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,3 @@ set -o pipefail
hack/verify-boilerplate.sh
hack/verify-chart-drift.sh
hack/verify-links.sh
hack/verify-govulncheck.sh
60 changes: 0 additions & 60 deletions hack/verify-govulncheck.sh
View file
Open in desktop

This file was deleted.

Loading