Skip to content

test/scale: add api conflicts metric to scale test reporting - #463

Open
rawadhossain wants to merge 1 commit into
kubernetes-sigs:mainfrom
rawadhossain:api-conflicts-scale
Open

test/scale: add api conflicts metric to scale test reporting#463
rawadhossain wants to merge 1 commit into
kubernetes-sigs:mainfrom
rawadhossain:api-conflicts-scale

Conversation

@rawadhossain

@rawadhossain rawadhossain commented Sep 6, 2026

Copy link
Copy Markdown
Member

Description

Extends the scale test harness to report node_readiness_api_conflicts_total metric and *ConflictExhausted failure reasons introduced in #320.

What's added

  • Scale test report now includes conflict and retry exhaustion numbers.
  • Added controller_runtime_reconcile_errors_total as a sanity check on retry exhaustion.
  • Fixed a gap where conflicts happening between phases weren't being counted.
  • Made sure that fix doesn't affect CPU, API rate, or latency numbers - those still use original measurement window.

Depends on #320

Testing

  • Full scale test ran successfully.
  • Verified the generated report and ran the full test/vet/lint suite.

Checklist

  • make test passes
  • make lint passes

@netlify

netlify Bot commented Sep 6, 2026

Copy link
Copy Markdown

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit e3715d1
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a9d39bb62c984000884bb1f

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rawadhossain
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant