Add inverter-control and dbus-mqtt-battery to default package list#134
Add inverter-control and dbus-mqtt-battery to default package list#1344alvit wants to merge 1 commit into
Conversation
c921a7b to
f26ed9b
Compare
- inverter-control: Victron inverter controller with D-term, burst logic - dbus-mqtt-battery: MQTT to D-Bus bridge for JBD BMS batteries Both maintained under victron-venus GitHub org.
f26ed9b to
0023ea2
Compare
|
The packages you wish me to add to SetupHelper set the packageName script variable. This should not be done in the setup script as it is done in SetupHelper's CommonResources. packageName MUST accurately match the directory name where the package is installed and if there is a descrepency in setting the variable in the setup script then operations will fail. It appears all package's setup scripts set the variable correctly so it is redundant, but the code should be removed from the setup scripts. I will add the three packages the next time I update SetupHelper. I don't use commits directly due to my development environment. |
|
Fixed. Removed redundant packageName lines from all three setup scripts:
SetupHelper's CommonResources now handles packageName directly. |
2 participants
Both maintained under victron-venus GitHub org.