Daily Test Coverage Improver - Fix coverage steps Vitest configuration#7964
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Daily Test Coverage Improver - Fix coverage steps Vitest configuration#7964github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Vitest uses the coverage.reportsDirectory setting from vitest.config.ts instead of the --coverageDirectory CLI flag. This was causing coverage steps to fail with 'Unknown option' error. The coverage directory is already configured in both: - react/vitest.config.ts (reportsDirectory: 'coverage') - packages/backend.ai-ui/vitest.config.ts (reportsDirectory: 'coverage') Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the coverage steps action to work with the current version of Vitest. The
--coverageDirectoryCLI flag is not supported by Vitest 4.x; instead, the coverage directory is configured via thecoverage.reportsDirectorysetting invitest.config.ts.Problem
The coverage steps were failing with:
Solution
Removed the
--coverageDirectory=coverageflag from both test commands. The coverage directory is already properly configured in:react/vitest.config.tswithcoverage.reportsDirectory: 'coverage'packages/backend.ai-ui/vitest.config.tswithcoverage.reportsDirectory: 'coverage'Changes
.github/actions/daily-test-improver/coverage-steps/action.yml: Removed--coverageDirectory=coveragefrom React and backend.ai-ui test commandsVerification
This fix allows the coverage steps to run successfully and generate coverage reports in the expected locations:
react/coverage/packages/backend.ai-ui/coverage/What Happens Next
Once this PR is merged, the daily test improver workflow can proceed with Phase 3 to implement actual test coverage improvements using the corrected coverage steps.