fix(FR-3204): keep model project folder mount permission read-only in Folder Explorer#8034
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
213a6b5 to
ddad0d2
Compare
There was a problem hiding this comment.
Pull request overview
This PR aligns Folder Explorer mount-permission editing behavior with the existing model project folder creation restriction (forced read-only), preventing users from switching such folders back to read-write when the backend feature flag is enabled. It also improves label consistency by explicitly naming the field “Mount Permission” in the creation modal.
Changes:
- Disable the
rwmount-permission option for model project folders in Folder Explorer whenallow-only-ro-permission-for-model-project-folderis supported, with an explanatory tooltip. - Rename the create-modal permission label to
data.folders.MountPermissionfor consistency with Folder Explorer terminology.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| react/src/components/VFolderNodeDescriptionV2.tsx | Gates and disables the rw mount-permission option for model project folders (feature-flagged), adds tooltip explanation, and adds a defensive early-return in onChange. |
| react/src/components/FolderCreateModalV2.tsx | Updates the permission field label to “Mount Permission” using the existing i18n key. |
a404b57 to
64d418d
Compare
agatha197
left a comment
There was a problem hiding this comment.
Add more design intent comments after discussing with core team.
64d418d to
c70c0ef
Compare
Merge activity
|
… Folder Explorer (#8034) Resolves #8033 (FR-3204) ## Summary   When a model folder is created into a project from the Model Store, the mount permission is forced to read-only (`ro`) at creation time (`FolderCreateModalV2` / FR-1290). However, the **Folder Explorer** detail panel still let users switch that permission back to read-write (`rw`), bypassing the enforcement. ## Changes - **`VFolderNodeDescriptionV2.tsx`** — Disable the `rw` mount-permission option for model project folders (`metadata.usageMode === 'MODEL'` && `accessControl.ownershipType === 'GROUP'`). A tooltip on the disabled option explains why, reusing the existing `data.folders.ModelProjectFolderRestrictedToReadOnly` message already shown in the create modal, plus a defensive `onChange` guard. - **`FolderCreateModalV2.tsx`** — Rename the permission field label from `data.Permission` ("권한") to `data.folders.MountPermission` ("마운트 권한") for consistency with the Folder Explorer, since both refer to the *mount* permission. Also drop the now-redundant feature-flag gate (see below). - **Dropped the `allow-only-ro-permission-for-model-project-folder` feature-flag gate** from both screens. The restriction is enforced by all currently supported manager versions (LTS ≥ 25.18.2), so the version gate was always `true` — a dead branch. Removing it from both call sites keeps the two screens consistent. ## Verification `bash scripts/verify.sh` → Relay / Lint / Format / TypeScript all PASS. (The pre-existing "Vite warmup paths" check fails on `main` as well, unrelated to this change.) ## Test plan 1. Create a model folder into a project folder from the Model Store (permission forced to `ro`). 2. Open it in Folder Explorer → the mount-permission `rw` option is disabled and shows the read-only tooltip on hover; only `ro` is selectable. 3. Non-model folders are unaffected — both `ro` and `rw` remain selectable.
c70c0ef to
da225f7
Compare

Resolves #8033 (FR-3204)
Summary
When a model folder is created into a project from the Model Store, the mount permission is forced to read-only (
ro) at creation time (FolderCreateModalV2/ FR-1290). However, the Folder Explorer detail panel still let users switch that permission back to read-write (rw), bypassing the enforcement.Changes
VFolderNodeDescriptionV2.tsx— Disable therwmount-permission option for model project folders (metadata.usageMode === 'MODEL'&&accessControl.ownershipType === 'GROUP'). A tooltip on the disabled option explains why, reusing the existingdata.folders.ModelProjectFolderRestrictedToReadOnlymessage already shown in the create modal, plus a defensiveonChangeguard.FolderCreateModalV2.tsx— Rename the permission field label fromdata.Permission("권한") todata.folders.MountPermission("마운트 권한") for consistency with the Folder Explorer, since both refer to the mount permission. Also drop the now-redundant feature-flag gate (see below).allow-only-ro-permission-for-model-project-folderfeature-flag gate from both screens. The restriction is enforced by all currently supported manager versions (LTS ≥ 25.18.2), so the version gate was alwaystrue— a dead branch. Removing it from both call sites keeps the two screens consistent.Verification
bash scripts/verify.sh→ Relay / Lint / Format / TypeScript all PASS.(The pre-existing "Vite warmup paths" check fails on
mainas well, unrelated to this change.)Test plan
ro).rwoption is disabled and shows the read-only tooltip on hover; onlyrois selectable.roandrwremain selectable.