feat: Expose per-mount subpath/alias/permission on SessionV2 GraphQL node by rapsealk · Pull Request #11966 · lablup/backend.ai

rapsealk · 2026-06-08T04:38:48Z

Summary

Exposes per-mount subpath, alias (mount destination), and permission (plus name, vfolder id, and usage mode) on the new Strawberry SessionV2 GraphQL node, replacing the # TODO: Add vfolder_mounts dynamic field placeholder.

The mount data already flows to the v2 adapter via SessionData.vfolder_mounts: list[VFolderMountData] | None, so no DB/loader/query change was needed. A new SessionMount DTO and SessionMountGQL output type were added, and the adapter now maps each VFolderMountData into the SessionNode DTO.

Field mapping

GraphQL field	Source
`vfolderId`	`vfid.folder_id`
`name`	`name`
`subpath`	`vfsubpath` (`"."` → `null`)
`mountDestination`	`kernel_path`
`permission`	`mount_perm`
`usageMode`	`usage_mode`

Supergraph composition succeeded with the schema name SessionMount (no collision with a legacy Graphene type), so no V2 suffix was required.

Test plan

pants fmt passes
pants fix passes
pants lint passes
pants check (mypy) passes
pants test passes
GraphQL schema regenerated (v2-schema.graphql, supergraph.graphql)
Unit test added for the adapter mount mapping (subpath, mount destination, permission, and "." → null normalization)
Live verification pending

Part of #11962
Resolves #11963

🤖 Generated with Claude Code

📚 Documentation preview 📚: https://sorna--11966.org.readthedocs.build/en/11966/

📚 Documentation preview 📚: https://sorna-ko--11966.org.readthedocs.build/ko/11966/

…node Surface vfolder mount metadata (subpath, alias/mount destination, and effective permission) on the Strawberry SessionV2 node via a new SessionMount DTO and SessionMountGQL type. Data already flows to the v2 adapter; it is now mapped into the SessionNode DTO and exposed. Resolves #11963 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR exposes per-mount virtual folder metadata on the Strawberry SessionV2 GraphQL node by introducing a dedicated mount DTO/type and wiring already-available SessionData.vfolder_mounts through the v2 session adapter into the GraphQL schema (replacing the previous TODO/placeholder).

Changes:

Added SessionMount DTO and included mounts: list[SessionMount] on SessionNode.
Mapped SessionData.vfolder_mounts → SessionNode.mounts in SessionAdapter._session_data_to_node(), including "." → null subpath normalization.
Added SessionMount GraphQL output type and exposed mounts on SessionV2, plus updated generated schemas and adapter unit tests.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`src/ai/backend/common/dto/manager/v2/session/response.py`	Introduces `SessionMount` DTO and adds `mounts` to `SessionNode` for downstream GraphQL exposure.
`src/ai/backend/manager/api/adapters/session/adapter.py`	Maps `SessionData.vfolder_mounts` into the new `SessionNode.mounts` structure (incl. subpath normalization).
`src/ai/backend/manager/api/gql/session/types.py`	Adds `SessionMount` GraphQL type and exposes `mounts` field on `SessionV2`.
`tests/unit/manager/api/adapters/test_session_adapter.py`	Adds unit coverage for mount mapping (subpath normalization, destination, permission, usage mode).
`docs/manager/graphql-reference/v2-schema.graphql`	Regenerated v2 schema to include `SessionMount` and `SessionV2.mounts`.
`docs/manager/graphql-reference/supergraph.graphql`	Regenerated supergraph schema to include the new type/field.
`changes/11966.feature.md`	Adds changelog entry for the new `SessionV2.mounts` exposure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…fo-v2 # Conflicts: # src/ai/backend/common/dto/manager/v2/session/response.py # src/ai/backend/manager/api/adapters/session/adapter.py # src/ai/backend/manager/api/gql/session/types.py

jopemachine · 2026-06-12T08:03:32Z

+class SessionMountGQL:
+    vfolder_id: UUID = gql_field(description="UUID of the mounted virtual folder.")
+    name: str = gql_field(description="Name of the mounted virtual folder.")
+    subpath: str | None = gql_field(
+        description="Subpath within the vfolder that is mounted. Null when the vfolder root is mounted."
+    )
+    mount_destination: str = gql_field(
+        description="Mount destination (alias) path inside the session container."
+    )
+    permission: str = gql_field(description="Effective mount permission (e.g., 'ro', 'rw').")
+    usage_mode: str = gql_field(description="Usage mode of the mounted virtual folder.")


It would be better to add a vfolder node field so that mount-specific information (e.g., subpath, permission, etc.) and VFolder information can be queried separately in a structured manner.

There used to be a convention that Node types were only attached to root types, but that convention does not seem applicable in this case.

Since the same vfolder can be mounted multiple times under different subpaths, it makes more sense for the mount itself to be associated with a vfolder node. This more accurately reflects the relationship between mounts and vfolders.

Good call — restructured accordingly. Each mount now exposes a vfolder: VFolder node (the v2 Strawberry VFolderGQL, resolved through the existing vfolder_loader), so folder-level information can be queried separately in a structured manner. As you noted, the same vfolder can be mounted multiple times under different subpaths, so the relationship lives on the mount itself.

The SessionMount type now carries only mount-specific fields — vfolderId, subpath, mountDestination, permission — while name/usageMode moved to vfolder.metadata:

type SessionMount { vfolderId: UUID! subpath: String mountDestination: String! permission: VFolderMountPermission! vfolder: VFolder }

jopemachine · 2026-06-12T08:04:14Z

+    mount_destination: str = gql_field(
+        description="Mount destination (alias) path inside the session container."
+    )
+    permission: str = gql_field(description="Effective mount permission (e.g., 'ro', 'rw').")


Since the VFolderMountPermissionGQL, VFolderUsageModeGQL type already exists, it would be better to use them

Done — permission now uses the existing VFolderMountPermission GQL enum (and VFolderPermissionField on the DTO side) instead of a bare string. usage_mode was dropped from the mount type itself (see the vfolder-node thread); it is now reachable via vfolder.metadata.usageMode.

jopemachine · 2026-06-12T08:12:56Z

+        added_version=NEXT_RELEASE_VERSION,
+        description="A single virtual folder mount on a session.",
+    ),
+    model=SessionMount,


Nit: SessionMountDTO

Renamed SessionMount → SessionMountDTO.

Address review feedback on per-mount metadata exposure: - Rename DTO `SessionMount` -> `SessionMountDTO`. - Type `permission` with the existing `VFolderMountPermission` GQL enum (`VFolderPermissionField` DTO) instead of a bare string. - Attach each mount to the v2 `VFolder` node via a `vfolder` resolver (using the existing `vfolder_loader`), so folder attributes can be queried separately in a structured manner. The same vfolder may be mounted multiple times under different subpaths, so the relationship belongs on the mount. - Keep only mount-specific fields on the mount type (subpath, mount destination, permission, vfolder id); drop `name`/`usage_mode` which are now reachable through `vfolder.metadata`. - Regenerate v2 and supergraph schemas; update adapter unit tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings June 8, 2026 04:38

rapsealk requested a review from a team as a code owner June 8, 2026 04:38

rapsealk added this to the 26.4 milestone Jun 8, 2026

feat: add changelog fragment

4197f27

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions Bot assigned rapsealk Jun 8, 2026

Copilot started reviewing on behalf of rapsealk June 8, 2026 04:38 View session

github-actions Bot added size:L 100~500 LoC comp:manager Related to Manager component type:enhance Enhance component, behavior, internals without user-facing features area:docs Documentations comp:common Related to Common component labels Jun 8, 2026

Copilot AI reviewed Jun 8, 2026

View reviewed changes

rapsealk requested a review from HyeockJinKim June 8, 2026 05:38

Merge remote-tracking branch 'origin/main' into feat/session-mount-in…

23951e1

…fo-v2 # Conflicts: # src/ai/backend/common/dto/manager/v2/session/response.py # src/ai/backend/manager/api/adapters/session/adapter.py # src/ai/backend/manager/api/gql/session/types.py

jopemachine reviewed Jun 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Expose per-mount subpath/alias/permission on SessionV2 GraphQL node#11966

feat: Expose per-mount subpath/alias/permission on SessionV2 GraphQL node#11966
rapsealk wants to merge 4 commits into
mainfrom
feat/session-mount-info-v2

rapsealk commented Jun 8, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

jopemachine Jun 12, 2026

Uh oh!

jopemachine Jun 12, 2026

Uh oh!

rapsealk Jun 25, 2026

Uh oh!

jopemachine Jun 12, 2026 •

edited

Loading

Uh oh!

rapsealk Jun 25, 2026

Uh oh!

jopemachine Jun 12, 2026

Uh oh!

rapsealk Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

rapsealk commented Jun 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Field mapping

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

jopemachine Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

jopemachine Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

rapsealk Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

jopemachine Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rapsealk Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

jopemachine Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

rapsealk Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rapsealk commented Jun 8, 2026 •

edited by github-actions Bot

Loading

jopemachine Jun 12, 2026 •

edited

Loading