fix(BA-6506): parametrize app/storage base domains#12206
Open
devyubin wants to merge 6 commits into
Open
Conversation
Drop the unused generate_passphrase() helper and its PASSPHRASE_CHARACTER_POOL (which was also non-cryptographic and had a malformed character pool), an unused duplicate SHELL lookup in configure_client(), and the empty configure.py module. Also fix the "Detetced" log typo.
devyubin
changed the title
seedspirit
reviewed
Jun 18, 2026
seedspirit
left a comment
seedspirit
left a comment
Contributor
There was a problem hiding this comment.
It looks fine overall, @Yaminyam could you please take a look?
| with self.resource_path( | ||
| "ai.backend.install.fixtures", "example-keypairs.json" | ||
| ) as keypair_path: | ||
| current_shell = os.environ.get("SHELL", "sh") |
Contributor
There was a problem hiding this comment.
Did you delete it because it was dead code?
Contributor
Author
There was a problem hiding this comment.
Yescurrent_shell was assigned twice with the same os.environ.get("SHELL", "sh"), once in the keypairs block and once in the users block, but only the users block reads it (if current_shell == "fish"). The keypairs-block copy was never used before that second assignment, so removing it changes nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #12205 (BA-6506)
Replaces the hardcoded Lablup-internal hostnames (
<prefix>.app.backend.ai,<prefix>.public.isla-sorna.backend.ai) that the installer built from--fqdn-prefixwith two injected options,--app-base-domainand--storage-base-domain. Those strings put internal infrastructure names in a public repo and tied the wildcard-domain install path to one deployment. With the new options unset the hostnames fall back to--public-facing-address, so IP-based installs are untouched. The branch also drops an internal collector IP from a help example and removes dead installer code: an unused passphrasehelper, a duplicate SHELL lookup, and an empty module.
Checklist: (if applicable)
ai.backend.testdocsdirectory