chore(lint): use expect_err in the image-capacity rejection test - #1292
Merged
Conversation
clippy 1.97 flags .err().expect() as err_expect, and the workspace gate runs with -D warnings, so a clean main fails local clippy since #1280. The two load_xla_image_preprocessor sites keep the .err().expect() shape: their Ok type does not implement Debug, so expect_err does not apply and the lint does not fire there.
inureyes
added
type:refactor
This was referenced Aug 22, 2026
perf(speculative): decide the MTP verify width by measured throughput, not an acceptance proxy
#1295
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy 1.97 flags
.err().expect()aserr_expect, and the workspace clippy gate runs with-D warnings, so a clean checkout ofmainfails local clippy since #1280 landed. One-line fix toexpect_err.The two
load_xla_image_preprocessorsites in the same file keep the.err().expect()shape: their Ok type does not implementDebug, soexpect_errdoes not apply and the lint does not fire there.Type of change
choreTest plan
cargo clippy -p mlxcel --all-targets --features metal,accelerate -- -D warningscleancargo test --release -p mlxcel --lib the_default_capacity_is_rejectedpasses