Skip to content

fix(ci): make ShellCheck coverage fail closed - #423

Open
ITSMERNB wants to merge 1 commit into
lacs-project:mainfrom
ITSMERNB:fix/shellcheck-coverage
Open

fix(ci): make ShellCheck coverage fail closed#423
ITSMERNB wants to merge 1 commit into
lacs-project:mainfrom
ITSMERNB:fix/shellcheck-coverage

Conversation

@ITSMERNB

Copy link
Copy Markdown
Contributor

Summary

  • make the ShellCheck file enumeration fail closed on missing roots and an empty scan
  • derive maintained shell files by shebang so extensionless hooks are covered
  • include .githooks/pre-commit and .githooks/pre-push
  • keep GitHub CI and ci-local on the same enumerator
  • add a release coverage gate over every tracked shell file with a count floor

Validation

  • bash -n scripts/shellcheck-files.sh tests/release/shellcheck-coverage.test.sh scripts/ci-local.sh
  • bash tests/release/shellcheck-coverage.test.sh -> 195 tracked shell files covered
  • missing-root fixture -> refused and names the missing root
  • empty-root fixture -> refused instead of passing over zero files
  • .githooks/pre-commit and .githooks/pre-push present in the derived scan
  • git diff --check

Closes #409

Signed-off-by: ITSMESB <131141975+ITSMERNB@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ShellCheck job passes when a search root disappears, and it never lints the two git hooks

1 participant