Various fixes detected on ubuntu 26.04#1977
Merged
Merged
Conversation
In file included from visp/modules/robot/src/haptic-device/virtuose/vpVirtuose.cpp:41:
isp/modules/robot/include/visp3/robot/vpVirtuose.h:169:8: error: ‘void visp::vpVirtuose::init()’ marked ‘override’, but does not override
169 | void init() VP_OVERRIDE;
| ^~~~
…adows a member
This warning is an issue.
visp/modules/detection/src/dnn/vpDetectorDNNOpenCV.cpp: In member function ‘void visp::vpDetectorDNNOpenCV::postProcess(DetectionCandidates&)’:
visp/modules/detection/src/dnn/vpDetectorDNNOpenCV.cpp:517:10: warning: declaration of ‘void visp::postProcess_SSD_MobileNet(vpDetectorDNNOpenCV::DetectionCandidates&, std::vector<cv::Mat>&, const vpDetectorDNNOpenCV::NetConfig&)’ shadows a member of ‘visp::vpDetectorDNNOpenCV’ [-Wshadow]
517 | void postProcess_SSD_MobileNet(DetectionCandidates & proposals, std::vector<cv::Mat> &dnnRes, const NetConfig & netConfig);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from visp/modules/detection/src/dnn/vpDetectorDNNOpenCV.cpp:41:
visp/modules/detection/include/visp3/detection/vpDetectorDNNOpenCV.h:578:8: note: shadowed declaration is here
578 | void postProcess_SSD_MobileNet(DetectionCandidates &proposals, std::vector<cv::Mat> &dnnRes, const NetConfig &netConfig);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
…ign of the result [-Wsign-conversion]
visp/apps/rs-dataset/visp-save-rs-dataset.cpp: In constructor ‘{anonymous}::vpStorageWorker::vpStorageWorker({anonymous}::vpFrameQueue&, const std::string&, const std::string&, bool, bool, bool, bool, bool, bool, bool, bool, unsigned int, unsigned int)’:
visp/apps/rs-dataset/visp-save-rs-dataset.cpp:491:19: warning: conversion to ‘int’ from ‘unsigned int’ may change the sign of the result [-Wsign-conversion]
491 | m_size_height(height), m_size_width(width)
| ^~~~~~
visp/apps/rs-dataset/visp-save-rs-dataset.cpp:491:41: warning: conversion to ‘int’ from ‘unsigned int’ may change the sign of the result [-Wsign-conversion]
491 | m_size_height(height), m_size_width(width)
| ^~~~~
visp/apps/rs-dataset/visp-save-rs-dataset.cpp: In member function ‘void {anonymous}::vpStorageWorker::run()’:
visp/apps/rs-dataset/visp-save-rs-dataset.cpp:581:30: warning: conversion to ‘uint32_t’ {aka ‘unsigned int’} from ‘int’ may change the sign of the result [-Wsign-conversion]
581 | uint32_t width = m_size_width;
| ^~~~~~~~~~~~
visp/apps/rs-dataset/visp-save-rs-dataset.cpp:582:31: warning: conversion to ‘uint32_t’ {aka ‘unsigned int’} from ‘int’ may change the sign of the result [-Wsign-conversion]
582 | uint32_t height = m_size_height;
| ^~~~~~~~~~~~~
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1977 +/- ##
==========================================
- Coverage 48.76% 48.73% -0.03%
==========================================
Files 532 532
Lines 69401 69397 -4
Branches 32432 32430 -2
==========================================
- Hits 33840 33822 -18
- Misses 31422 31436 +14
Partials 4139 4139 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…itialized [-Wuninitialized]
Occurs when visp builds static libraries on ununtu 26.04
In member function ‘void visp::vpStatisticalTestAbstract::setNbSamplesForStat(const unsigned int&)’,
inlined from ‘visp::vpStatisticalTestAbstract& visp::vpStatisticalTestAbstract::operator=(const visp::vpStatisticalTestAbstract&)’ at visp/modules/core/src/math/misc/vpStatisticalTestAbstract.cpp:181:24,
inlined from ‘visp::vpStatisticalTestAbstract::vpStatisticalTestAbstract(const visp::vpStatisticalTestAbstract&)’ at visp/modules/core/src/math/misc/vpStatisticalTestAbstract.cpp:146:11:
visp/modules/core/src/math/misc/vpStatisticalTestAbstract.cpp:196:7: warning: ‘*this.visp::vpStatisticalTestAbstract::m_s’ is used uninitialized [-Wuninitialized]
196 | if (m_s != nullptr) {
| ^~~
…t&, visp::vpImageCircle const&) Occurs when visp build static libraries /usr/bin/x86_64-linux-gnu-ld.bfd: ../../../lib/libvisp_core.a(vpImageCircle.cpp.o): in function `visp::operator==(visp::vpImageCircle const&, visp::vpImageCircle const&)': vpImageCircle.cpp:(.text+0x49c0): multiple definition of `visp::operator==(visp::vpImageCircle const&, visp::vpImageCircle const&)'; ../../../lib/libvisp_imgproc.a(vpCircleHoughTransform_common.cpp.o)
Fix by inlining nlohmann::json convertCommandLineArgument<std::string>(const std::string &arg) that is a specialization of convertCommandLineArgument() template Issue occurs when visp builds static libraries /usr/bin/x86_64-linux-gnu-ld.bfd: ../../lib/libvisp_io.a(vpJsonArgumentParser.cpp.o): in function `nlohmann::json_abi_v3_11_3::basic_json<std::map, std::vector, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_11_3::adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> >, void> convertCommandLineArgument<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)': vpJsonArgumentParser.cpp:(.text+0x3ff0): multiple definition of `nlohmann::json_abi_v3_11_3::basic_json<std::map, std::vector, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, bool, long, unsigned long, double, std::allocator, nlohmann::json_abi_v3_11_3::adl_serializer, std::vector<unsigned char, std::allocator<unsigned char> >, void> convertCommandLineArgument<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'; CMakeFiles/catchJsonArgumentParser.dir/test/catchJsonArgumentParser.cpp.o:catchJsonArgumentParser.cpp:(.text+0x41a0): first defined here [ 37%] Built target testMouseEvent collect2: error: ld returned 1 exit status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.